You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/01/07 18:43:32 UTC
[GitHub] [solr] epugh opened a new pull request #503: SOLR-15897 Remove from test solrconfig.xml
epugh opened a new pull request #503:
URL: https://github.com/apache/solr/pull/503
https://issues.apache.org/jira/browse/SOLR-15897
# Description
Unit tests have deprecated <jmx/> tags in solrconfig.xml
# Solution
Removed <jmx/> from test solrconfigs.xml plus a configset related to jmx that is not used.
# Tests
Re ran the tests.
# Checklist
Please review the following and check all that apply:
- [X ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ X] I have created a Jira issue and added the issue ID to my pull request title.
- [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ X] I have developed this patch against the `main` branch.
- [ X] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #503: SOLR-15897 Remove from test solrconfig.xml
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #503:
URL: https://github.com/apache/solr/pull/503#issuecomment-1009317061
Test-only cleanups can be considered for 9.0.0 too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a change in pull request #503: SOLR-15897 Remove from test solrconfig.xml
Posted by GitBox <gi...@apache.org>.
epugh commented on a change in pull request #503:
URL: https://github.com/apache/solr/pull/503#discussion_r781507443
##########
File path: solr/CHANGES.txt
##########
@@ -427,6 +427,8 @@ Other Changes
* SOLR-15807: New LogListener class for tests to use to make assertions about what Log messages should or should not be produced by a test (hossman)
+* SOLR-15897: Remove <jmx/> from all unit test solrconfig.xml files. (Eric Pugh)
+
Review comment:
Okay, I think I just did the back port...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on pull request #503: SOLR-15897 Remove from test solrconfig.xml
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #503:
URL: https://github.com/apache/solr/pull/503#issuecomment-1010246605
> @janhoy would the 9.1.0 section be added as part of the 9.0.0 release process (at some point) or can/should developers add it as/when the need arises? Somehow I'm thinking the former but maybe things are different for a major release etc.
Partly answering own question: `branch_9x` has https://github.com/apache/solr/commit/e9a47a4b9a1d41bb9c1991b1c1cae5170618dd51#diff-cdd1ae1b418ea74ca689c6e68e61f4e5b4c6f77f6408a4e6cf76ed8421b24d09
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #503: SOLR-15897 Remove from test solrconfig.xml
Posted by GitBox <gi...@apache.org>.
epugh merged pull request #503:
URL: https://github.com/apache/solr/pull/503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a change in pull request #503: SOLR-15897 Remove from test solrconfig.xml
Posted by GitBox <gi...@apache.org>.
epugh commented on a change in pull request #503:
URL: https://github.com/apache/solr/pull/503#discussion_r781505522
##########
File path: solr/CHANGES.txt
##########
@@ -427,6 +427,8 @@ Other Changes
* SOLR-15807: New LogListener class for tests to use to make assertions about what Log messages should or should not be produced by a test (hossman)
+* SOLR-15897: Remove <jmx/> from all unit test solrconfig.xml files. (Eric Pugh)
+
Review comment:
thanks! I think I didn't quite understand how the branches worked ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on pull request #503: SOLR-15897 Remove from test solrconfig.xml
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #503:
URL: https://github.com/apache/solr/pull/503#issuecomment-1010242799
> @cpoerschke can you review now? Did I get the CHANGES.txt right? I want this to not go in Solr 9.0.0. I would like it to eventually go in Solr 9.1.0 however.
Interesting, there's no 9.1.0 section as yet in CHANGES.txt on `main` (and so the location right now is the 10.0.0 section actually).
@janhoy would the 9.1.0 section be added as part of the 9.0.0 release process (at some point) or can/should developers add it as/when the need arises? Somehow I'm thinking the former but maybe things are different for a major release etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #503: SOLR-15897 Remove from test solrconfig.xml
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #503:
URL: https://github.com/apache/solr/pull/503#discussion_r781413280
##########
File path: solr/CHANGES.txt
##########
@@ -427,6 +427,8 @@ Other Changes
* SOLR-15807: New LogListener class for tests to use to make assertions about what Log messages should or should not be produced by a test (hossman)
+* SOLR-15897: Remove <jmx/> from all unit test solrconfig.xml files. (Eric Pugh)
+
Review comment:
Addition here presumes backporting to `branch_9_0_0` branch, I have no views for or against that, just noting it as part of checking the entry is in the correct section :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #503: SOLR-15897 Remove from test solrconfig.xml
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #503:
URL: https://github.com/apache/solr/pull/503#issuecomment-1009302162
@cpoerschke can you review now? Did I get the CHANGES.txt right? I want this to not go in Solr 9.0.0. I would like it to eventually go in Solr 9.1.0 however.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org