You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by ajs6f <gi...@git.apache.org> on 2018/03/09 15:21:21 UTC

[GitHub] jena pull request #377: JENA-1503: Bug in XSDDateTime toString

GitHub user ajs6f opened a pull request:

    https://github.com/apache/jena/pull/377

    JENA-1503: Bug in XSDDateTime toString

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ajs6f/jena JENA-1503

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/377.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #377
    
----
commit bd1ee9ed2a0aebc055f8b280e31fe087686934c8
Author: ajs6f <aj...@...>
Date:   2018-03-09T15:19:28Z

    JENA-1503: Bug in XSDDateTime toString

----


---

[GitHub] jena pull request #377: JENA-1503: Bug in XSDDateTime toString

Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:

    https://github.com/apache/jena/pull/377#discussion_r173497971
  
    --- Diff: jena-core/src/test/java/org/apache/jena/graph/test/TestTypedLiterals.java ---
    @@ -989,7 +991,17 @@ public void testXSDanyURI() {
             Node node2 = NodeFactory.createLiteral("http://example/", XSDDatatype.XSDstring) ;
             assertFalse(node1.sameValueAs(node2)) ;
         }
    -    
    +
    +    /**
    +     * Test a user error report concerning date/time literals from JENA-1503
    +     */
    +    public void testDateTimeBug3() {
    +        final RDFDatatype XSDdateTime = TypeMapper.getInstance().getSafeTypeByName(XSD.dateTime.getURI());
    --- End diff --
    
    More FYI than anything else: There is a constant `XSDDatatype.XSDdateTime`.


---

[GitHub] jena pull request #377: JENA-1503: Bug in XSDDateTime toString

Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on a diff in the pull request:

    https://github.com/apache/jena/pull/377#discussion_r173498951
  
    --- Diff: jena-core/src/test/java/org/apache/jena/graph/test/TestTypedLiterals.java ---
    @@ -989,7 +991,17 @@ public void testXSDanyURI() {
             Node node2 = NodeFactory.createLiteral("http://example/", XSDDatatype.XSDstring) ;
             assertFalse(node1.sameValueAs(node2)) ;
         }
    -    
    +
    +    /**
    +     * Test a user error report concerning date/time literals from JENA-1503
    +     */
    +    public void testDateTimeBug3() {
    +        final RDFDatatype XSDdateTime = TypeMapper.getInstance().getSafeTypeByName(XSD.dateTime.getURI());
    --- End diff --
    
    Hey, let's model good behavior! (Says the father of two toddlers.) I'll add a commit right now.


---

[GitHub] jena pull request #377: JENA-1503: Bug in XSDDateTime toString

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/jena/pull/377


---