You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hainenber (via GitHub)" <gi...@apache.org> on 2024/06/15 09:49:50 UTC
[PR] chore(frontend): uplift Cypress to v13 [superset]
hainenber opened a new pull request, #29265:
URL: https://github.com/apache/superset/pull/29265
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
chore(frontend): uplift Cypress to v13
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Uplift Cypress to currency (v13). Acceptance threshold is all Cypress tests in CI pass with flying colors :D
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(frontend): uplift Cypress to v13 [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #29265:
URL: https://github.com/apache/superset/pull/29265#discussion_r1680184407
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts:
##########
@@ -524,10 +524,141 @@ describe('Drill by modal', () => {
});
it('Bar Chart V2', () => {
- testEchart('echarts_timeseries_bar', 'Bar Chart V2', [
+ const vizType = 'echarts_timeseries_bar';
+ const chartName = 'Bar Chart V2';
+ const drillClickCoordinates = [
[70, 94],
- [362, 68],
- ]);
+ [362, 474],
Review Comment:
Yeah coordinates are always flakey in cypress as things can always add or subtract to it. You could try writing a function where you can pass in what you are looking for and then it'll generate an approximate window coordinate for you. I have that in our repo and it's still flakey but i'm not adding prs to make these updates as much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(frontend): uplift Cypress to v13 [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #29265:
URL: https://github.com/apache/superset/pull/29265#discussion_r1643214428
##########
superset-frontend/cypress-base/cypress.config.ts:
##########
@@ -37,30 +36,10 @@ export default eyesPlugin(
openMode: 0,
},
e2e: {
+ experimentalMemoryManagement: true,
Review Comment:
I see we are doing `{ testIsolation: false }` in the describe blocks, is there a reason to not just add that to the config instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(frontend): uplift Cypress to v13 [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #29265:
URL: https://github.com/apache/superset/pull/29265#issuecomment-2231993029
I'm generally bullish on landing this, despite the subtle flavoring of the voodoo before/after. Can't comment on specific issues here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(frontend): uplift Cypress to v13 [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #29265:
URL: https://github.com/apache/superset/pull/29265#issuecomment-2613964157
Closed due to inactivity. A Playwright migration PR could be better in terms of p/p
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(frontend): uplift Cypress to v13 [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #29265:
URL: https://github.com/apache/superset/pull/29265#discussion_r1641896914
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts:
##########
@@ -588,7 +719,7 @@ describe('Drill by modal', () => {
it('Gauge Chart', () => {
testEchart('gauge_chart', 'Gauge Chart', [
[151, 95],
- [300, 143],
+ [300, NaN], // this fixes the test after upgrading to Cypress 13
Review Comment:
This is completely voodoo magic to me. Previous coordinates didn't work and frustratingly I entered `NaN` and it worked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(frontend): uplift Cypress to v13 [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber closed pull request #29265: chore(frontend): uplift Cypress to v13
URL: https://github.com/apache/superset/pull/29265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(frontend): uplift Cypress to v13 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #29265:
URL: https://github.com/apache/superset/pull/29265#issuecomment-2170370538
Hey, thanks for getting into this! This'll enable some cool stuff, including test playback on the Cypress dashboard, which is pretty nifty!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(frontend): uplift Cypress to v13 [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #29265:
URL: https://github.com/apache/superset/pull/29265#discussion_r1641897913
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/nativeFilters.test.ts:
##########
@@ -428,14 +428,13 @@ describe('Native filters', () => {
cy.contains(testItems.filterDefaultValue).should('be.visible');
cy.contains(testItems.filterOtherCountry).should('not.exist');
});
+ validateFilterContentOnDashboard(testItems.filterDefaultValue);
// reload dashboard
cy.reload();
cy.get(dataTestChartName(testItems.topTenChart.name)).within(() => {
cy.contains(testItems.filterDefaultValue).should('be.visible');
- cy.contains(testItems.filterOtherCountry).should('not.exist');
Review Comment:
`cy.reload()` in Cypress 13 seems to completely remove local cache for stored filter inputs. Lmk if my change here is a fix or a band-aid :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(frontend): uplift Cypress to v13 [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #29265:
URL: https://github.com/apache/superset/pull/29265#discussion_r1641896603
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts:
##########
@@ -524,10 +524,141 @@ describe('Drill by modal', () => {
});
it('Bar Chart V2', () => {
- testEchart('echarts_timeseries_bar', 'Bar Chart V2', [
+ const vizType = 'echarts_timeseries_bar';
+ const chartName = 'Bar Chart V2';
+ const drillClickCoordinates = [
[70, 94],
- [362, 68],
- ]);
+ [362, 474],
Review Comment:
I'm not sure if it's due to Cypress upgrade or else but the previous coordinates were flaky. I have to manually tinker around to pick out the least "flaky" coordinates to pass local CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org