[GitHub] [incubator-eventmesh] walterlife commented on issue #2537: [Enhancement] Method stores return result in local before immediately returning it [UserAgent]

[GitBox <gi...@apache.org>]

walterlife commented on issue #2537:
URL: https://github.com/apache/incubator-eventmesh/issues/2537#issuecomment-1345732196

   1. The original code has no performance problems, and code style problems
   2. Although the modified code looks more concise, it actually has some side effects. For example, a single line is too complex, the readability is poor, and the testability is poor.
   more details can read the google code review guide in depth.
   https://google.github.io/eng-practices/review/reviewer/looking-for.html#complexity


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org