[GitHub] [iceberg] aokolnychyi commented on a change in pull request #3984: Spark 3.2: Implement merge-on-read UPDATE

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #3984:
URL: https://github.com/apache/iceberg/pull/3984#discussion_r792159480



##########
File path: core/src/main/java/org/apache/iceberg/io/BasePositionDeltaWriter.java
##########
@@ -27,25 +27,35 @@
 
 public class BasePositionDeltaWriter<T> implements PositionDeltaWriter<T> {
 
-  private final PartitioningWriter<T, DataWriteResult> dataWriter;
+  private final PartitioningWriter<T, DataWriteResult> insertWriter;

Review comment:
       Let's discuss the interface change instead (below).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org