[GitHub] [calcite] chunweilei commented on a change in pull request #1636: [CALCITE-3568] BigQuery, Hive, Spark SQL dialects don't support nested aggregates

[GitBox <gi...@apache.org>]

chunweilei commented on a change in pull request #1636: [CALCITE-3568] BigQuery, Hive, Spark SQL dialects don't support nested aggregates
URL: https://github.com/apache/calcite/pull/1636#discussion_r354641356
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/dialect/SparkSqlDialect.java
 ##########
 @@ -70,6 +70,10 @@ public SparkSqlDialect(SqlDialect.Context context) {
     return true;
   }
 
+  @Override public boolean supportsNestedAggregations() {
+    return false;
+  }
+
 
 Review comment:
   IMO, the title of this issue is a little confusing. What I get from the title is BigQuery/Hive/Spark should support nested aggregate, but we don't. However, the fact is BigQuery/Hive/Spark support nested aggregate wrongly. So I suggest changing it. What about `BigQuery, Hive, Spark SQL dialects support nested aggregates wrongly`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services