[GitHub] [arrow-rs] viirya commented on a diff in pull request #1647: Exclude `dict_id` and `dict_is_ordered` from equality comparison of `Field`

[GitBox <gi...@apache.org>]

viirya commented on code in PR #1647:
URL: https://github.com/apache/arrow-rs/pull/1647#discussion_r866234751


##########
arrow/src/datatypes/field.rs:
##########
@@ -27,7 +28,7 @@ use super::DataType;
 /// Contains the meta-data for a single relative type.
 ///
 /// The `Schema` object is an ordered collection of `Field` objects.
-#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Eq, Hash, PartialOrd, Ord)]
+#[derive(Serialize, Deserialize, Debug, Clone, PartialOrd, Ord)]

Review Comment:
   Hmm, okay, I just considered equality comparison case, I think it is mostly common. Not sure when exact order between `Field` would be needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org