You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry <am...@hortonworks.com> on 2018/05/01 20:58:40 UTC
Review Request 66891: DSL ITs: Deprecated ITs removed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66891/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-2401, ATLAS-2402, ATLAS-2403, ATLAS-2404, ATLAS-2412, ATLAS-2413, ATLAS-2414, ATLAS-2415, ATLAS-2416, and ATLAS-2417
https://issues.apache.org/jira/browse/ATLAS-2401
https://issues.apache.org/jira/browse/ATLAS-2402
https://issues.apache.org/jira/browse/ATLAS-2403
https://issues.apache.org/jira/browse/ATLAS-2404
https://issues.apache.org/jira/browse/ATLAS-2412
https://issues.apache.org/jira/browse/ATLAS-2413
https://issues.apache.org/jira/browse/ATLAS-2414
https://issues.apache.org/jira/browse/ATLAS-2415
https://issues.apache.org/jira/browse/ATLAS-2416
https://issues.apache.org/jira/browse/ATLAS-2417
Repository: atlas
Description
-------
**Background**
There was a transition period in the v1.0 release timeframe, where earlier DSL implementation was removed and its replacement was under development. During this time, ITs related to the older DSL implementation were failing. These ITs were disabled.
**Approach**
The new DSL implementation has its tests in:
- _GremlinQueryComposerTest_: Unit-test that specifically tests query composition.
- _DSLQueriesTest_: Tests include executing queries (400+ in number) from service layer.
These cover the functionaly exhaustively.
Given this, it is prudent to remove the deprecated tests.
Diffs
-----
webapp/src/test/java/org/apache/atlas/web/integration/EntityDiscoveryJerseyResourceIT.java 52b7a46fb
webapp/src/test/java/org/apache/atlas/web/integration/MetadataDiscoveryJerseyResourceIT.java 16287182b
Diff: https://reviews.apache.org/r/66891/diff/1/
Testing
-------
**Unit tests**
Coverage (using IntelliJ) of the new set of tests mentioned above is over 96%.
Thanks,
Ashutosh Mestry
Re: Review Request 66891: DSL ITs: Deprecated ITs removed
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66891/#review202218
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On May 1, 2018, 8:58 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66891/
> -----------------------------------------------------------
>
> (Updated May 1, 2018, 8:58 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2401, ATLAS-2402, ATLAS-2403, ATLAS-2404, ATLAS-2412, ATLAS-2413, ATLAS-2414, ATLAS-2415, ATLAS-2416, and ATLAS-2417
> https://issues.apache.org/jira/browse/ATLAS-2401
> https://issues.apache.org/jira/browse/ATLAS-2402
> https://issues.apache.org/jira/browse/ATLAS-2403
> https://issues.apache.org/jira/browse/ATLAS-2404
> https://issues.apache.org/jira/browse/ATLAS-2412
> https://issues.apache.org/jira/browse/ATLAS-2413
> https://issues.apache.org/jira/browse/ATLAS-2414
> https://issues.apache.org/jira/browse/ATLAS-2415
> https://issues.apache.org/jira/browse/ATLAS-2416
> https://issues.apache.org/jira/browse/ATLAS-2417
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Background**
> There was a transition period in the v1.0 release timeframe, where earlier DSL implementation was removed and its replacement was under development. During this time, ITs related to the older DSL implementation were failing. These ITs were disabled.
>
> **Approach**
> The new DSL implementation has its tests in:
> - _GremlinQueryComposerTest_: Unit-test that specifically tests query composition.
> - _DSLQueriesTest_: Tests include executing queries (400+ in number) from service layer.
>
> These cover the functionaly exhaustively.
>
> Given this, it is prudent to remove the deprecated tests.
>
>
> Diffs
> -----
>
> webapp/src/test/java/org/apache/atlas/web/integration/EntityDiscoveryJerseyResourceIT.java 52b7a46fb
> webapp/src/test/java/org/apache/atlas/web/integration/MetadataDiscoveryJerseyResourceIT.java 16287182b
>
>
> Diff: https://reviews.apache.org/r/66891/diff/1/
>
>
> Testing
> -------
>
> **Unit tests**
> Coverage (using IntelliJ) of the new set of tests mentioned above is over 96%.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>