You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jun Rao (JIRA)" <ji...@apache.org> on 2012/10/04 18:57:47 UTC
[jira] [Commented] (KAFKA-502) Simplify setup / initialization in
replication_basic_test.py
[ https://issues.apache.org/jira/browse/KAFKA-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469506#comment-13469506 ]
Jun Rao commented on KAFKA-502:
-------------------------------
Thanks for patch v3. This looks great.
0. Do all new tests pass right now? How long will it take to run all tests?
1. The description in each test case can be improved. For example, in the following description, steps 06 and 07 are being done in every test case. It's ok to include the detailed steps in each test case. However, it would be useful to describe what's unique (say compared to testcase_1) about a particular test case at the very beginning of the description. This way, if some test cases fail, we can quickly understand the unique features about them. Also, can we spell out comp as compression?
+ "description": {"01":"To Test : 'Leader Failure in Replication'",
+ "02":"Produce and consume messages to a single topic - single partition.",
+ "03":"This test sends messages to 6 replicas",
+ "04":"To trigger leader election: find the leader and terminate by controlled failure (kill -15)",
+ "05":"Restart the terminated broker",
+ "06":"Lookup brokers' log4j messages and verify that leader is re-elected successfully",
+ "07":"At the end it verifies the log size and contents",
+ "08":"Use a consumer to verify no message loss.",
+ "09":"Producer dimensions : mode:async, acks:-1, comp:1",
+ "10":"Log segment size : 10240"
2. run_sanity.sh seems to run in debug mode that logs a lot of debugging statements. Is this necessary? Also, in my local box, it has been running for more than 20 mins and hasn't finished. That test used to take less than 6 mins.
3. Mirror maker testsuite: Do we bounce the leader in both the source and the target clusters? If so, do we bounce them at the same time? Just want to clarify how this works.
> Simplify setup / initialization in replication_basic_test.py
> ------------------------------------------------------------
>
> Key: KAFKA-502
> URL: https://issues.apache.org/jira/browse/KAFKA-502
> Project: Kafka
> Issue Type: Sub-task
> Affects Versions: 0.8
> Reporter: John Fung
> Assignee: John Fung
> Labels: replication-testing
> Fix For: 0.8
>
> Attachments: kafka-502-v1.patch, kafka-502-v2.patch, kafka-502-v3.patch
>
>
> The setup and initialization could be simplified by moving some common code to a base class or some helper functions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira