You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhiwei Chen <zh...@gmail.com> on 2016/03/22 06:07:09 UTC
Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support Power
LE platform.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44376/
-----------------------------------------------------------
(Updated March 22, 2016, 1:07 p.m.)
Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone.
Summary (updated)
-----------------
Upgrade zookeeper to 3.4.8 to support Power LE platform.
Bugs: MESOS-4612
https://issues.apache.org/jira/browse/MESOS-4612
Repository: mesos
Description (updated)
-------
Upgrade zookeeper to 3.4.8 to support Power LE platform.
Diffs (updated)
-----
3rdparty/Makefile.am 49aa55741d76aa88c8fbb526f18908312bb0c717
3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7
3rdparty/versions.am c2dae2fb521b12344b93bf771dd5497ba8d446c3
3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da
3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc
3rdparty/zookeeper-3.4.8.patch PRE-CREATION
src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1
src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520
src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670
Diff: https://reviews.apache.org/r/44376/diff/
Testing (updated)
-------
sudo make dist check
sudo ./src/mesos-tests --benchmark
sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
Thanks,
Zhiwei Chen
Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support Power
LE platform.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44376/#review124772
-----------------------------------------------------------
Bad patch!
Reviews applied: [44376]
Failed command: ./support/apply-review.sh -n -r 44376
Error:
2016-03-22 11:20:54 URL:https://reviews.apache.org/r/44376/diff/raw/ [9419/9419] -> "44376.patch" [1]
error: missing binary patch data for '3rdparty/zookeeper-3.4.8.tar.gz'
error: binary patch does not apply to '3rdparty/zookeeper-3.4.5.tar.gz'
error: 3rdparty/zookeeper-3.4.5.tar.gz: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/12091/console
- Mesos ReviewBot
On March 22, 2016, 5:07 a.m., Zhiwei Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44376/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 5:07 a.m.)
>
>
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone.
>
>
> Bugs: MESOS-4612
> https://issues.apache.org/jira/browse/MESOS-4612
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Upgrade zookeeper to 3.4.8 to support Power LE platform.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 49aa55741d76aa88c8fbb526f18908312bb0c717
> 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7
> 3rdparty/versions.am c2dae2fb521b12344b93bf771dd5497ba8d446c3
> 3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da
> 3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc
> 3rdparty/zookeeper-3.4.8.patch PRE-CREATION
> src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1
> src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520
> src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670
>
> Diff: https://reviews.apache.org/r/44376/diff/
>
>
> Testing
> -------
>
> sudo make dist check
>
> sudo ./src/mesos-tests --benchmark
>
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
>
>
> Thanks,
>
> Zhiwei Chen
>
>
Re: Review Request 44376: [WIP]Upgrade zookeeper to 3.4.8 to support
PowerPC LE platform.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44376/#review125488
-----------------------------------------------------------
Bad patch!
Reviews applied: [44376]
Failed command: ./support/apply-review.sh -n -r 44376
Error:
2016-03-25 23:32:22 URL:https://reviews.apache.org/r/44376/diff/raw/ [9344/9344] -> "44376.patch" [1]
error: unrecognized binary patch at line 152
Total errors found: 0
Checking 1 files
Error: Commit message summary (the first line) must start with a capital letter.
Full log: https://builds.apache.org/job/mesos-reviewbot/12145/console
- Mesos ReviewBot
On March 24, 2016, 12:33 p.m., Zhiwei Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44376/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 12:33 p.m.)
>
>
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone.
>
>
> Bugs: MESOS-4612
> https://issues.apache.org/jira/browse/MESOS-4612
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 49aa55741d76aa88c8fbb526f18908312bb0c717
> 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7
> 3rdparty/versions.am c2dae2fb521b12344b93bf771dd5497ba8d446c3
> 3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da
> 3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc
> 3rdparty/zookeeper-3.4.8.patch PRE-CREATION
> src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1
> src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520
> src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670
>
> Diff: https://reviews.apache.org/r/44376/diff/
>
>
> Testing
> -------
>
> sudo make dist check
>
> sudo ./src/mesos-tests --benchmark
>
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
>
>
> Thanks,
>
> Zhiwei Chen
>
>
Re: Review Request 44376: [WIP]Upgrade zookeeper to 3.4.8 to support
PowerPC LE platform.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44376/#review125468
-----------------------------------------------------------
Regarding testing: The upgrade script doesn't really test ZK upgrade because it doesn't bring up ZK server (there's a TODO for that).
Can you update the upgrade script to add ZK support (basically bring up ZK and let masters, agents and framework talk to it)? You can add that as a separate review to this chain.
3rdparty/Makefile.am (line 54)
<https://reviews.apache.org/r/44376/#comment188265>
Does this comment still apply? AFAICT MESOS-1797 doesn't apply to ZK 3.4.8 since that issue has been resolved in ZK 3.4.7.
3rdparty/zookeeper-3.4.8.patch (lines 1 - 19)
<https://reviews.apache.org/r/44376/#comment188266>
Is this a fix for PPC? Can you explain what the problem and fix is?
I would recommend to split this patch into 2 patches
1) Just for ZK upgrade to 3.4.8
2) Patch create/update for PPC
src/tests/zookeeper_test_server.cpp (line 142)
<https://reviews.apache.org/r/44376/#comment188267>
Have you confirmed that this is still an issue with ZK 3.4.8?
- Vinod Kone
On March 24, 2016, 12:33 p.m., Zhiwei Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44376/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 12:33 p.m.)
>
>
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone.
>
>
> Bugs: MESOS-4612
> https://issues.apache.org/jira/browse/MESOS-4612
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 49aa55741d76aa88c8fbb526f18908312bb0c717
> 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7
> 3rdparty/versions.am c2dae2fb521b12344b93bf771dd5497ba8d446c3
> 3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da
> 3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc
> 3rdparty/zookeeper-3.4.8.patch PRE-CREATION
> src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1
> src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520
> src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670
>
> Diff: https://reviews.apache.org/r/44376/diff/
>
>
> Testing
> -------
>
> sudo make dist check
>
> sudo ./src/mesos-tests --benchmark
>
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
>
>
> Thanks,
>
> Zhiwei Chen
>
>
Re: Review Request 44376: [WIP]Upgrade zookeeper to 3.4.8 to support
PowerPC LE platform.
Posted by Zhiwei Chen <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44376/
-----------------------------------------------------------
(Updated March 24, 2016, 8:33 p.m.)
Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone.
Summary (updated)
-----------------
[WIP]Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.
Bugs: MESOS-4612
https://issues.apache.org/jira/browse/MESOS-4612
Repository: mesos
Description
-------
Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.
Diffs (updated)
-----
3rdparty/Makefile.am 49aa55741d76aa88c8fbb526f18908312bb0c717
3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7
3rdparty/versions.am c2dae2fb521b12344b93bf771dd5497ba8d446c3
3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da
3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc
3rdparty/zookeeper-3.4.8.patch PRE-CREATION
src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1
src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520
src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670
Diff: https://reviews.apache.org/r/44376/diff/
Testing
-------
sudo make dist check
sudo ./src/mesos-tests --benchmark
sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
Thanks,
Zhiwei Chen
Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support
PowerPC LE platform.
Posted by Zhiwei Chen <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44376/
-----------------------------------------------------------
(Updated March 24, 2016, 4:58 p.m.)
Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone.
Summary (updated)
-----------------
Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.
Bugs: MESOS-4612
https://issues.apache.org/jira/browse/MESOS-4612
Repository: mesos
Description (updated)
-------
Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.
Diffs (updated)
-----
3rdparty/Makefile.am 49aa55741d76aa88c8fbb526f18908312bb0c717
3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7
3rdparty/versions.am c2dae2fb521b12344b93bf771dd5497ba8d446c3
3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da
3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc
3rdparty/zookeeper-3.4.8.patch PRE-CREATION
src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1
src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520
src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670
Diff: https://reviews.apache.org/r/44376/diff/
Testing
-------
sudo make dist check
sudo ./src/mesos-tests --benchmark
sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
Thanks,
Zhiwei Chen