You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "tbw777 (via GitHub)" <gi...@apache.org> on 2023/03/04 17:45:38 UTC
[GitHub] [netbeans] tbw777 opened a new pull request, #5598: A lot of typos fixed
tbw777 opened a new pull request, #5598:
URL: https://github.com/apache/netbeans/pull/5598
BUILD SUCCESSFUL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1460752677
I still see little value in changing typos in the code. This is a > 500k LOC project, we really don't have time to review typos in half a million lines of code for developer-facing files.
Are there any typos in user-facing files somewhere, perhaps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #5598: A lot of typos fixed
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125524176
##########
ide/html.parser/external/htmlparser-01-fix-maven-build.patch:
##########
@@ -45,7 +45,7 @@ diff --git a/src/nu/validator/htmlparser/dom/HtmlDocumentBuilder.java b/src/nu/v
--- a/src/nu/validator/htmlparser/dom/HtmlDocumentBuilder.java
+++ b/src/nu/validator/htmlparser/dom/HtmlDocumentBuilder.java
@@ -377,26 +377,26 @@ public class HtmlDocumentBuilder extends
- public void setTransitionHander(TransitionHandler handler) {
+ public void setTransitionHandler(TransitionHandler handler) {
Review Comment:
> This file "Fix error in maven build when run on JDK8" and therefore should be removed
Don't guess. Especially not when you are fixing "typos".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on a diff in pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125517192
##########
groovy/groovy.editor/test/qa-functional/src/org/netbeans/test/groovy/cc/testCCMixed.java:
##########
@@ -196,9 +196,9 @@ public void ImportPackage() {
type(file, "\n public static int testInt(){\n return 0;");
new EventTool().waitNoEvent(1000);
file.save();
- createGroovyFile(TEST_BASE_NAME + (name_iterator - 1), "Groovy Class", "EEE", "org.netbens.groovy");
+ createGroovyFile(TEST_BASE_NAME + (name_iterator - 1), "Groovy Class", "EEE", "org.netbeans.groovy");
Review Comment:
netbens fixed at 159fcdc8
corresponding change used in L201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1457928202
Similar error on origin/master
What i need to do next?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1455071178
To simplify the review process i replaced all changes by incomments only.
The rest will be commited in other PR.
Reson: most part of all changes are incomments only and its too hard to simultiniosly do analze different type of changes.
Checks status for current changes:
clean: ok
build : ok
ant rat: ok
ant verify-libs-and-licenses: ok
ant commit-validation: ok
ant tryme quick tests: no exceptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 closed pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 closed pull request #5598: A lot of typos fixed
URL: https://github.com/apache/netbeans/pull/5598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on a diff in pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125525072
##########
ide/html.parser/external/htmlparser-01-fix-maven-build.patch:
##########
@@ -45,7 +45,7 @@ diff --git a/src/nu/validator/htmlparser/dom/HtmlDocumentBuilder.java b/src/nu/v
--- a/src/nu/validator/htmlparser/dom/HtmlDocumentBuilder.java
+++ b/src/nu/validator/htmlparser/dom/HtmlDocumentBuilder.java
@@ -377,26 +377,26 @@ public class HtmlDocumentBuilder extends
- public void setTransitionHander(TransitionHandler handler) {
+ public void setTransitionHandler(TransitionHandler handler) {
Review Comment:
ok, reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1129942118
##########
php/php.editor/test/unit/data/testfiles/completion/lib/nb1855/nb1855.php.testCompleteAccessPrefix_01.completion:
##########
@@ -39,8 +39,8 @@ VARIABLE ? publicTraitProperty [PUBLIC] Trait1855
CONSTANT PRIVATE_CONSTANT "private cons [PRIVATE] Class1855
CONSTANT PROTECTED_CONSTANT "protected [PROTECTE Class1855
CONSTANT PROTECTED_PARENT_CONSTANT "pro [PROTECTE ParentClass
-CONSTANT PUBLIC_CONSTANT "pubic constan [PUBLIC] Class1855
-CONSTANT PUBLIC_PARENT_CONSTANT "pubic [PUBLIC] ParentClass
+CONSTANT PUBLIC_CONSTANT "public consta [PUBLIC] Class1855
+CONSTANT PUBLIC_PARENT_CONSTANT "public [PUBLIC] ParentClass
Review Comment:
Same two questions for this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1454687488
Hi @tbw777 ,
Note that posting a PR for review, making reviewers review it, and then closing it is not very polite.
If you continue doing this then no reviewers will spend their spare time in reviewing PRs that you then close at will, that's wasting time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125550819
##########
ide/team.commons/src/org/netbeans/modules/team/spi/TeamAccessor.java:
##########
@@ -35,7 +35,7 @@
public abstract class TeamAccessor {
public static final String PROP_LOGIN = "team.login.changed"; // NOI18N
- public static final String PROP_PROJETCS_CHANGED = "team.projects.changed"; // NOI18N
+ public static final String PROP_PROJECTS_CHANGED = "team.projects.changed"; // NOI18N
Review Comment:
Marking things as deprecated is not enough when you're changing an API. To change a public API/SPI you have to:
* Ask in the mailing list if the change is acceptable or not.
* Ask in the mailing list for instructions on how to change a public API (marking things as "deprecated" is not good enough).
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 closed pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 closed pull request #5598: A lot of typos fixed
URL: https://github.com/apache/netbeans/pull/5598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1129941856
##########
php/php.editor/test/unit/data/testfiles/completion/lib/nb1855/nb1855.php.testCompleteAccessPrefixInClassConst_01.completion:
##########
@@ -6,8 +6,8 @@ CLASS ParentClass [PUBLIC] nb1855.php
CONSTANT PRIVATE_CONSTANT "private cons [PRIVATE] Class1855
CONSTANT PROTECTED_CONSTANT "protected [PROTECTE Class1855
CONSTANT PROTECTED_PARENT_CONSTANT "pro [PROTECTE ParentClass
-CONSTANT PUBLIC_CONSTANT "pubic constan [PUBLIC] Class1855
-CONSTANT PUBLIC_PARENT_CONSTANT "pubic [PUBLIC] ParentClass
+CONSTANT PUBLIC_CONSTANT "public consta [PUBLIC] Class1855
+CONSTANT PUBLIC_PARENT_CONSTANT "public [PUBLIC] ParentClass
Review Comment:
So you're changing a ".completion" test file.
Questions:
1) Can you explain how these completion test work?
2) Does this module pass an `ant test` after this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on a diff in pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125516943
##########
enterprise/web.beans/test/unit/src/org/netbeans/modules/web/beans/model/InterceptorResolutionTest.java:
##########
@@ -138,7 +138,7 @@ public void testInterceptorNonbindingMembers() throws IOException{
"@Target({METHOD, TYPE}) "+
"public @interface IBinding2 {" +
" String value() ;"+
- " @Nonbinding String comment() defualt \"\" ; "+
+ " @Nonbinding String comment() default \"\" ; "+
Review Comment:
over bindings are equal. Is this correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125515141
##########
enterprise/web.jsf.navigation/src/org/netbeans/modules/web/jsf/navigation/graph/PageFlowSceneData.java:
##########
@@ -45,7 +45,7 @@ public class PageFlowSceneData {
* Because the actual Page object is not necessarily the same, it uses the display name
* as the key.
* @param scene PageFlowScene
- * @param utilities PageFlowUtilites
+ * @param utilities PageFlowUtilities
Review Comment:
That's not a proper description of that "utilities" variable, is it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on a diff in pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125517061
##########
enterprise/web.jsf.navigation/src/org/netbeans/modules/web/jsf/navigation/graph/PageFlowSceneData.java:
##########
@@ -45,7 +45,7 @@ public class PageFlowSceneData {
* Because the actual Page object is not necessarily the same, it uses the display name
* as the key.
* @param scene PageFlowScene
- * @param utilities PageFlowUtilites
+ * @param utilities PageFlowUtilities
Review Comment:
yes: Utilit i es
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125515640
##########
ide/css.lib/src/org/netbeans/modules/css/lib/Css3.g:
##########
@@ -2046,5 +2046,5 @@ LINE_COMMENT
;
// -------------
-// Illegal. Any other character shoudl not be allowed.
+// Illegal. Any other character should not be allowed.
Review Comment:
You're changing a grammar file. Did you regenerate the grammar afterwards?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1461345841
php tests reverted.
First step is to fix tests or we change plans?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on a diff in pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125518364
##########
ide/css.visual/src/org/netbeans/modules/css/visual/SelectorsGroupEditor.java:
##########
@@ -111,7 +111,7 @@ private void initComponents() {
selectElementComboBox = new javax.swing.JComboBox();
selectClassRadioButton = new javax.swing.JRadioButton();
selectClassTextField = new javax.swing.JTextField();
- selectElelmentIdRadioButton = new javax.swing.JRadioButton();
+ selectElementIdRadioButton = new javax.swing.JRadioButton();
Review Comment:
8000efbc fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125515890
##########
ide/html.parser/external/htmlparser-01-fix-maven-build.patch:
##########
@@ -45,7 +45,7 @@ diff --git a/src/nu/validator/htmlparser/dom/HtmlDocumentBuilder.java b/src/nu/v
--- a/src/nu/validator/htmlparser/dom/HtmlDocumentBuilder.java
+++ b/src/nu/validator/htmlparser/dom/HtmlDocumentBuilder.java
@@ -377,26 +377,26 @@ public class HtmlDocumentBuilder extends
- public void setTransitionHander(TransitionHandler handler) {
+ public void setTransitionHandler(TransitionHandler handler) {
Review Comment:
You're changing a diff file here, are the offsets still correct? Or will this patch file be broken after your change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on a diff in pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125517192
##########
groovy/groovy.editor/test/qa-functional/src/org/netbeans/test/groovy/cc/testCCMixed.java:
##########
@@ -196,9 +196,9 @@ public void ImportPackage() {
type(file, "\n public static int testInt(){\n return 0;");
new EventTool().waitNoEvent(1000);
file.save();
- createGroovyFile(TEST_BASE_NAME + (name_iterator - 1), "Groovy Class", "EEE", "org.netbens.groovy");
+ createGroovyFile(TEST_BASE_NAME + (name_iterator - 1), "Groovy Class", "EEE", "org.netbeans.groovy");
Review Comment:
netbens fixed at 159fcdc8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1454826901
@vieiro what commits do i need to revert?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1469451899
i reviewed changes and not found any principal. Therefore this shitty pr is closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1129942377
##########
php/php.editor/test/unit/data/testfiles/completion/lib/php54/traitsMultiUse.php.testTraitsMultiUse1.completion:
##########
@@ -4,8 +4,8 @@ $this->|publicFirstField;
METHOD functionName() [PUBLIC] WithMultiUses
METHOD privateFirstMethod() [PRIVATE] FirstTrait
METHOD privateSecondMethod() [PRIVATE] SecondTrait
-METHOD protecedFirstMethod() [PROTECTE FirstTrait
-METHOD protecedSecondMethod() [PROTECTE SecondTrait
+METHOD protectedFirstMethod() [PROTECTE FirstTrait
+METHOD protectedSecondMethod() [PROTECTE SecondTrait
Review Comment:
Here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on a diff in pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125519240
##########
ide/team.commons/src/org/netbeans/modules/team/spi/TeamAccessor.java:
##########
@@ -35,7 +35,7 @@
public abstract class TeamAccessor {
public static final String PROP_LOGIN = "team.login.changed"; // NOI18N
- public static final String PROP_PROJETCS_CHANGED = "team.projects.changed"; // NOI18N
+ public static final String PROP_PROJECTS_CHANGED = "team.projects.changed"; // NOI18N
Review Comment:
fixed in 0a41da3a
mark previos name as deprecated
##########
ide/team.commons/src/org/netbeans/modules/team/spi/TeamAccessor.java:
##########
@@ -35,7 +35,7 @@
public abstract class TeamAccessor {
public static final String PROP_LOGIN = "team.login.changed"; // NOI18N
- public static final String PROP_PROJETCS_CHANGED = "team.projects.changed"; // NOI18N
+ public static final String PROP_PROJECTS_CHANGED = "team.projects.changed"; // NOI18N
Review Comment:
fixed in 0a41da3a
marked previos name as deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on a diff in pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125518768
##########
ide/html.parser/external/htmlparser-01-fix-maven-build.patch:
##########
@@ -45,7 +45,7 @@ diff --git a/src/nu/validator/htmlparser/dom/HtmlDocumentBuilder.java b/src/nu/v
--- a/src/nu/validator/htmlparser/dom/HtmlDocumentBuilder.java
+++ b/src/nu/validator/htmlparser/dom/HtmlDocumentBuilder.java
@@ -377,26 +377,26 @@ public class HtmlDocumentBuilder extends
- public void setTransitionHander(TransitionHandler handler) {
+ public void setTransitionHandler(TransitionHandler handler) {
Review Comment:
file reverted in 537ad69d to remove in feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on a diff in pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125518908
##########
java/i18n/src/org/netbeans/modules/i18n/wizard/AdditionalWizardPanel.java:
##########
@@ -218,7 +218,7 @@ public static class Panel extends I18nWizardDescriptor.Panel {
private transient AdditionalWizardPanel additionalPanel;
Panel () {
- emptyLabel = new JLabel(Util.getString("TXT_HasNoAdditonal"));//NOI18N
+ emptyLabel = new JLabel(Util.getString("TXT_HasNoAdditional"));//NOI18N
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125516315
##########
java/i18n/src/org/netbeans/modules/i18n/wizard/AdditionalWizardPanel.java:
##########
@@ -218,7 +218,7 @@ public static class Panel extends I18nWizardDescriptor.Panel {
private transient AdditionalWizardPanel additionalPanel;
Panel () {
- emptyLabel = new JLabel(Util.getString("TXT_HasNoAdditonal"));//NOI18N
+ emptyLabel = new JLabel(Util.getString("TXT_HasNoAdditional"));//NOI18N
Review Comment:
Is this changed in the corresponding Bundle file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1130594900
##########
php/php.editor/test/unit/data/testfiles/completion/lib/nb1855/nb1855.php.testCompleteAccessPrefixInClassConst_01.completion:
##########
@@ -6,8 +6,8 @@ CLASS ParentClass [PUBLIC] nb1855.php
CONSTANT PRIVATE_CONSTANT "private cons [PRIVATE] Class1855
CONSTANT PROTECTED_CONSTANT "protected [PROTECTE Class1855
CONSTANT PROTECTED_PARENT_CONSTANT "pro [PROTECTE ParentClass
-CONSTANT PUBLIC_CONSTANT "pubic constan [PUBLIC] Class1855
-CONSTANT PUBLIC_PARENT_CONSTANT "pubic [PUBLIC] ParentClass
+CONSTANT PUBLIC_CONSTANT "public consta [PUBLIC] Class1855
+CONSTANT PUBLIC_PARENT_CONSTANT "public [PUBLIC] ParentClass
Review Comment:
What are the answers to these two questions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1455166423
clean: ok
build : ok
ant tryme quick tests: no exceptions
ant rat: ok
ant commit-validation: timeout (one unknown problem, doesnt depend to changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1454858767
> I agree that I need to run tests. I found how I can do it today. But I had a number of questions. Is it enough to run the command: ant test?
There are many kind of tests, ranging from unit tests to functional tests. Post a question in the mailing list to get some guidance, or consult the tutorials.
Note that the comments I've added are only those I found in a quick review. You're expected to review **all of the rest of changes** in these few hundred files, and make sure that:
* you're not changing APIs/SPIs,
* that all form you're changing can be opened in the IDE (this is, that Java code is in sync with the corresponding form and Bundle files).
* that all tests pass in the affected modules.
* that you can run the IDE (`ant tryme`) and that the forms that you've changed are working properly (this is, that no exception is thrown making the IDE or the form unusable).
Once you've done all these changes and tests then:
* squash the commits (`git rebase -i` may be of help)
* and then force push to this same branch (`git push -f`).
* Then ask for another review again.
We expect you're focused in this PR, making it pristine for our review, and that you won't open any other new PRs that do not match these quality criteria.
The goal of all this work is to have a new version of NetBeans that behaves **exactly the same** for end users (because users won't notice that you have renamed internal variables, because you have made sure that all tests work, and because you have made sure that forms don't break).
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on a diff in pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125517531
##########
ide/css.editor/src/org/netbeans/modules/css/editor/ui/CssRuleCreateActionDialog.java:
##########
@@ -135,7 +135,7 @@ private void initComponents() {
selectElementComboBox = new javax.swing.JComboBox();
selectClassRadioButton = new javax.swing.JRadioButton();
selectClassTextField = new javax.swing.JTextField();
- selectElelmentIdRadioButton = new javax.swing.JRadioButton();
+ selectElementIdRadioButton = new javax.swing.JRadioButton();
Review Comment:
you are right here, fixed in new fdad92f1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on a diff in pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125518210
##########
ide/css.lib/src/org/netbeans/modules/css/lib/Css3.g:
##########
@@ -2046,5 +2046,5 @@ LINE_COMMENT
;
// -------------
-// Illegal. Any other character shoudl not be allowed.
+// Illegal. Any other character should not be allowed.
Review Comment:
This is comment line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1468757235
Hi @tbw777 ,
So we don't really want to correct typos in source code/comments that are not visible to the user. We prefer to focus the reviewers effort in things that have more impact on end users (solving bugs, adding new features, etc.). After all users don't bother what we name internal variables.
Modifying tests without understanding them is also problematic, as you could see for yourself tests take long time to run (specially PHP, which is tested thoroughly). Modifying test files to correct typos may alter the internal indexes we use in these files (specially in editor features) and may make tests to fail.
So what about closing this one and moving onto the next PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1454847993
I added some quick reviews. A more thorough review will take much more time.
In this quick review, I've seen that:
- You correct some typos in internal variables, some documentation and elsewhere.
- You modify tests without really testing them (you say "BUILD SUCCESSFUL", but not "ALL TESTS OK").
- You modify diff files.
- You change public APIs/SPIs.
- This requires reviewer's time.
You have to understand that "Build successful" is not enough.
You have to build, test and possibly run things before submitting the PRs, because we don't have time to spend reviewing hundreds of changes to files that break our tests and make our APIs backwards incompatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125515511
##########
ide/css.editor/src/org/netbeans/modules/css/editor/ui/CssRuleCreateActionDialog.java:
##########
@@ -135,7 +135,7 @@ private void initComponents() {
selectElementComboBox = new javax.swing.JComboBox();
selectClassRadioButton = new javax.swing.JRadioButton();
selectClassTextField = new javax.swing.JTextField();
- selectElelmentIdRadioButton = new javax.swing.JRadioButton();
+ selectElementIdRadioButton = new javax.swing.JRadioButton();
Review Comment:
You're changing a variable name, did you change the corresponding .form file as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125515021
##########
enterprise/web.beans/test/unit/src/org/netbeans/modules/web/beans/model/InterceptorResolutionTest.java:
##########
@@ -138,7 +138,7 @@ public void testInterceptorNonbindingMembers() throws IOException{
"@Target({METHOD, TYPE}) "+
"public @interface IBinding2 {" +
" String value() ;"+
- " @Nonbinding String comment() defualt \"\" ; "+
+ " @Nonbinding String comment() default \"\" ; "+
Review Comment:
Are you changing a test here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #5598: A lot of typos fixed
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125518382
##########
ide/css.lib/src/org/netbeans/modules/css/lib/Css3.g:
##########
@@ -2046,5 +2046,5 @@ LINE_COMMENT
;
// -------------
-// Illegal. Any other character shoudl not be allowed.
+// Illegal. Any other character should not be allowed.
Review Comment:
Do not change the grammar if there is no error to fix. I question fixing typos in non-user-facing code in general and in this case I plain object it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on a diff in pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125517821
##########
ide/css.editor/test/unit/data/testfiles/netbeans.css.formatted:
##########
@@ -515,7 +515,7 @@ img.right {
}
/* -------------------------- */
-/* ----------- Docs & Suport spec styles -------------*/
+/* ----------- Docs & Support spec styles -------------*/
Review Comment:
dependings are changed at 6bf545f6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1454853007
I agree that I need to run tests. I found how I can do it today. But I had a number of questions. It is enough to run the command: ant test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125515273
##########
groovy/groovy.editor/test/qa-functional/src/org/netbeans/test/groovy/cc/testCCMixed.java:
##########
@@ -196,9 +196,9 @@ public void ImportPackage() {
type(file, "\n public static int testInt(){\n return 0;");
new EventTool().waitNoEvent(1000);
file.save();
- createGroovyFile(TEST_BASE_NAME + (name_iterator - 1), "Groovy Class", "EEE", "org.netbens.groovy");
+ createGroovyFile(TEST_BASE_NAME + (name_iterator - 1), "Groovy Class", "EEE", "org.netbeans.groovy");
Review Comment:
You're changing a test here. Did you test it afterwards?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125515718
##########
ide/css.visual/src/org/netbeans/modules/css/visual/SelectorsGroupEditor.java:
##########
@@ -111,7 +111,7 @@ private void initComponents() {
selectElementComboBox = new javax.swing.JComboBox();
selectClassRadioButton = new javax.swing.JRadioButton();
selectClassTextField = new javax.swing.JTextField();
- selectElelmentIdRadioButton = new javax.swing.JRadioButton();
+ selectElementIdRadioButton = new javax.swing.JRadioButton();
Review Comment:
You're changing an UI variable name, did you change the corresponding .form file as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125516616
##########
ide/team.commons/src/org/netbeans/modules/team/spi/TeamAccessor.java:
##########
@@ -35,7 +35,7 @@
public abstract class TeamAccessor {
public static final String PROP_LOGIN = "team.login.changed"; // NOI18N
- public static final String PROP_PROJETCS_CHANGED = "team.projects.changed"; // NOI18N
+ public static final String PROP_PROJECTS_CHANGED = "team.projects.changed"; // NOI18N
Review Comment:
You're changing a public NetBeans API/SPI without prior discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125515566
##########
ide/css.editor/test/unit/data/testfiles/netbeans.css.formatted:
##########
@@ -515,7 +515,7 @@ img.right {
}
/* -------------------------- */
-/* ----------- Docs & Suport spec styles -------------*/
+/* ----------- Docs & Support spec styles -------------*/
Review Comment:
You're changing a test file, did you test the module afterwards?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on a diff in pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1125518581
##########
ide/html.parser/external/htmlparser-01-fix-maven-build.patch:
##########
@@ -45,7 +45,7 @@ diff --git a/src/nu/validator/htmlparser/dom/HtmlDocumentBuilder.java b/src/nu/v
--- a/src/nu/validator/htmlparser/dom/HtmlDocumentBuilder.java
+++ b/src/nu/validator/htmlparser/dom/HtmlDocumentBuilder.java
@@ -377,26 +377,26 @@ public class HtmlDocumentBuilder extends
- public void setTransitionHander(TransitionHandler handler) {
+ public void setTransitionHandler(TransitionHandler handler) {
Review Comment:
This file
"Fix error in maven build when run on JDK8"
and therefore should be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #5598: A lot of typos fixed
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1455089798
Hi @tbw777 ,
I think most NetBeans committers will understand NetBeans source code without a need to change any "typos" in comments. These can be changed in future commits when required. So correcting these typos is not useful nor for final users nor for developers. As explained in the mailing list, let's focus on tests, if there are any improvements in tests you can provide.
Also, quoting Matthias:
> Do not change the grammar if there is no error to fix. I question fixing typos in non-user-facing code in general and in this case I plain object it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1454686807
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on a diff in pull request #5598: A lot of typos fixed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on code in PR #5598:
URL: https://github.com/apache/netbeans/pull/5598#discussion_r1133293521
##########
php/php.editor/test/unit/data/testfiles/completion/lib/nb1855/nb1855.php.testCompleteAccessPrefixInClassConst_01.completion:
##########
@@ -6,8 +6,8 @@ CLASS ParentClass [PUBLIC] nb1855.php
CONSTANT PRIVATE_CONSTANT "private cons [PRIVATE] Class1855
CONSTANT PROTECTED_CONSTANT "protected [PROTECTE Class1855
CONSTANT PROTECTED_PARENT_CONSTANT "pro [PROTECTE ParentClass
-CONSTANT PUBLIC_CONSTANT "pubic constan [PUBLIC] Class1855
-CONSTANT PUBLIC_PARENT_CONSTANT "pubic [PUBLIC] ParentClass
+CONSTANT PUBLIC_CONSTANT "public consta [PUBLIC] Class1855
+CONSTANT PUBLIC_PARENT_CONSTANT "public [PUBLIC] ParentClass
Review Comment:
omg how long test is
1. no
2. too long execution to test. I run it with ant test from php/php.editor
##########
php/php.editor/test/unit/data/testfiles/completion/lib/nb1855/nb1855.php.testCompleteAccessPrefixInClassConst_01.completion:
##########
@@ -6,8 +6,8 @@ CLASS ParentClass [PUBLIC] nb1855.php
CONSTANT PRIVATE_CONSTANT "private cons [PRIVATE] Class1855
CONSTANT PROTECTED_CONSTANT "protected [PROTECTE Class1855
CONSTANT PROTECTED_PARENT_CONSTANT "pro [PROTECTE ParentClass
-CONSTANT PUBLIC_CONSTANT "pubic constan [PUBLIC] Class1855
-CONSTANT PUBLIC_PARENT_CONSTANT "pubic [PUBLIC] ParentClass
+CONSTANT PUBLIC_CONSTANT "public consta [PUBLIC] Class1855
+CONSTANT PUBLIC_PARENT_CONSTANT "public [PUBLIC] ParentClass
Review Comment:
omg how long test is (or cycled)
1. no
2. too long execution to test. I run it with ant test from php/php.editor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists