You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2011/02/06 15:37:29 UTC
svn commit: r1067678 - /subversion/trunk/subversion/libsvn_fs_util/caching.c
Author: stefan2
Date: Sun Feb 6 14:37:29 2011
New Revision: 1067678
URL: http://svn.apache.org/viewvc?rev=1067678&view=rev
Log:
Changing caching defaults to "16MB membuffer cache, fulltext caching on".
* subversion/libsvn_fs_util/caching.c:
(cache_settings): change defaults
Modified:
subversion/trunk/subversion/libsvn_fs_util/caching.c
Modified: subversion/trunk/subversion/libsvn_fs_util/caching.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_util/caching.c?rev=1067678&r1=1067677&r2=1067678&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_util/caching.c (original)
+++ subversion/trunk/subversion/libsvn_fs_util/caching.c Sun Feb 6 14:37:29 2011
@@ -32,9 +32,9 @@ static svn_fs_cache_config_t cache_setti
{
/* default configuration:
*/
- 0x8000000, /* 128 MB for caches */
+ 0x1000000, /* 16 MB for caches */
16, /* up to 16 files kept open */
- FALSE, /* don't cache fulltexts */
+ TRUE, /* cache fulltexts */
FALSE, /* don't cache text deltas */
FALSE /* assume multi-threaded operation */
};
Re: svn commit: r1067678 - /subversion/trunk/subversion/libsvn_fs_util/caching.c
Posted by Stefan Fuhrmann <eq...@web.de>.
On 07.02.2011 13:40, Philip Martin wrote:
> stefan2@apache.org writes:
>
>> Author: stefan2
>> Date: Sun Feb 6 14:37:29 2011
>> New Revision: 1067678
>>
>> URL: http://svn.apache.org/viewvc?rev=1067678&view=rev
>> Log:
>> Changing caching defaults to "16MB membuffer cache, fulltext caching on".
>>
>> * subversion/libsvn_fs_util/caching.c:
>> (cache_settings): change defaults
>>
>> Modified:
>> subversion/trunk/subversion/libsvn_fs_util/caching.c
>>
>> Modified: subversion/trunk/subversion/libsvn_fs_util/caching.c
>> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_util/caching.c?rev=1067678&r1=1067677&r2=1067678&view=diff
>> ==============================================================================
>> --- subversion/trunk/subversion/libsvn_fs_util/caching.c (original)
>> +++ subversion/trunk/subversion/libsvn_fs_util/caching.c Sun Feb 6 14:37:29 2011
>> @@ -32,9 +32,9 @@ static svn_fs_cache_config_t cache_setti
>> {
>> /* default configuration:
>> */
>> - 0x8000000, /* 128 MB for caches */
>> + 0x1000000, /* 16 MB for caches */
> I'd like a comment in the code about that magic number. Is it a guess?
> Based on some sort of testing? Copied from some other program? A big
> server or a small workstation?
>
> I don't mind if it is just a guess so long as there is a comment that
> says it's a guess.
>
Done in r1068212.
-- Stefan^2.
Re: svn commit: r1067678 - /subversion/trunk/subversion/libsvn_fs_util/caching.c
Posted by Philip Martin <ph...@wandisco.com>.
stefan2@apache.org writes:
> Author: stefan2
> Date: Sun Feb 6 14:37:29 2011
> New Revision: 1067678
>
> URL: http://svn.apache.org/viewvc?rev=1067678&view=rev
> Log:
> Changing caching defaults to "16MB membuffer cache, fulltext caching on".
>
> * subversion/libsvn_fs_util/caching.c:
> (cache_settings): change defaults
>
> Modified:
> subversion/trunk/subversion/libsvn_fs_util/caching.c
>
> Modified: subversion/trunk/subversion/libsvn_fs_util/caching.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_util/caching.c?rev=1067678&r1=1067677&r2=1067678&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_fs_util/caching.c (original)
> +++ subversion/trunk/subversion/libsvn_fs_util/caching.c Sun Feb 6 14:37:29 2011
> @@ -32,9 +32,9 @@ static svn_fs_cache_config_t cache_setti
> {
> /* default configuration:
> */
> - 0x8000000, /* 128 MB for caches */
> + 0x1000000, /* 16 MB for caches */
I'd like a comment in the code about that magic number. Is it a guess?
Based on some sort of testing? Copied from some other program? A big
server or a small workstation?
I don't mind if it is just a guess so long as there is a comment that
says it's a guess.
> 16, /* up to 16 files kept open */
> - FALSE, /* don't cache fulltexts */
> + TRUE, /* cache fulltexts */
> FALSE, /* don't cache text deltas */
> FALSE /* assume multi-threaded operation */
> };
>
--
Philip