You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "htynkn (GitHub)" <gi...@apache.org> on 2019/01/10 13:20:00 UTC
[GitHub] [incubator-dubbo] htynkn opened issue #3186: Remove
unnessary content for pom file
- [x] I have searched the [issues](https://github.com/apache/incubator-dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/incubator-dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
Now dubbo requires java 8 or above, I notice there are still some configuration or profile for java6 (and hudson?)
Those content is not nessary any more, we need clean up it.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3186 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] kezhenxu94 commented on issue #3186:
Remove unnessary content for pom file
Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
I'll take this
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3186 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] CrazyHZM commented on issue #3186: Remove
unnessary content for pom file
Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
> I think the following detail need check:
>
> 1. argline set -Xmx to 512M
> 2. profile - java6 need remove
> 3. profile - test need remove?
> 4. profile - hudson need remove
> 5. profile - java8-vm-args need remove
> 6. maven-source-plugin - hard code version, should use properties
The first configuration seems to exist already, what do you think?
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3186 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 commented on issue #3186: Remove
unnessary content for pom file
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
> In my impression, dubbo will not support jdk lower version than version 8 when the 3.0 version realease ?
Dubbo will only support Java 8 and above from 2.7 onwards.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3186 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] tswstarplanet commented on issue #3186:
Remove unnessary content for pom file
Posted by "tswstarplanet (GitHub)" <gi...@apache.org>.
In my impression, dubbo will not support jdk lower version than version 8 when the 3.0 version realease ?
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3186 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] htynkn commented on issue #3186: Remove
unnessary content for pom file
Posted by "htynkn (GitHub)" <gi...@apache.org>.
I think the following detail need check:
1. argline set -Xmx to 512M? (do we really need this? or just let JVM decide)
2. profile - java6 need remove
3. profile - test need remove?
4. profile - hudson need remove
5. profile - java8-vm-args need remove
6. maven-source-plugin - hard code version, should use properties
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3186 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] htynkn commented on issue #3186: Remove
unnessary content for pom file
Posted by "htynkn (GitHub)" <gi...@apache.org>.
I think the following detail need check:
1. argline set -Xmx to 512M
2. profile - java6 need remove
3. profile - test need remove?
4. profile - hudson need remove
5. profile - java8-vm-args need remove
6. maven-source-plugin - hard code version, should use properties
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3186 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 commented on issue #3186: Remove
unnessary content for pom file
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
@htynkn Maybe you can add some detail items that can be done, so that someone could come in to help.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3186 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] htynkn closed issue #3186: Remove
unnessary content for pom file
Posted by "htynkn (GitHub)" <gi...@apache.org>.
[ issue closed by htynkn ]
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3186 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] htynkn commented on issue #3186: Remove
unnessary content for pom file
Posted by "htynkn (GitHub)" <gi...@apache.org>.
> > I think the following detail need check:
> >
> > 1. argline set -Xmx to 512M
> > 2. profile - java6 need remove
> > 3. profile - test need remove?
> > 4. profile - hudson need remove
> > 5. profile - java8-vm-args need remove
> > 6. maven-source-plugin - hard code version, should use properties
>
> The first configuration seems to exist already, what do you think?
sorry, I mean do we really limit memory to 512M? or it's better let JVM decide?
will add explanation for item 1
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3186 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] tswstarplanet commented on issue #3186:
Remove unnessary content for pom file
Posted by "tswstarplanet (GitHub)" <gi...@apache.org>.
In my impression, dubbo will not support lower version than jdk 8 when the 3.0 version realease ?
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3186 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org