You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/06/12 17:41:51 UTC
[kudu-CR](branch-1.17.x) [build-support] unset * proxy env variables for Python tests
Hello Abhishek Chennaka,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/20044
to review the following change.
Change subject: [build-support] unset *_proxy env variables for Python tests
......................................................................
[build-support] unset *_proxy env variables for Python tests
The environment of a Jenkins node might have HTTP/HTTPS proxy configured
to proxy HTTP requests even for 127.0.0.0/8 network and other quirks.
Since Python Kudu tests don't assume any proxying of HTTP/HTTPS requests
to Kudu components listening on 127.0.0.0/8 and other addresses,
let's explicitly unset environment variables that might affect behavior
of the Python libraries like urllib/urllib2 [1][2].
The motivation for this change was observing failures of the new Python
tests introduced with 8c546ae7f560deebb32cb04815377f74470643c6 when
running pre-commit Jenkins jobs on nodes of some peculiar network
configuration.
[1] https://docs.python.org/3/library/urllib.request.html
[2] https://docs.python.org/2/library/urllib2.html
Change-Id: I5a4d785e1eddf3b66c897a23f6b6c5d0b92392de
Reviewed-on: http://gerrit.cloudera.org:8080/20012
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit 459207ff5c103e7d4d60d974504eb8633e188d15)
---
M build-support/jenkins/build-and-test.sh
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/20044/1
--
To view, visit http://gerrit.cloudera.org:8080/20044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a4d785e1eddf3b66c897a23f6b6c5d0b92392de
Gerrit-Change-Number: 20044
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
[kudu-CR](branch-1.17.x) [build-support] unset * proxy env variables for Python tests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [build-support] unset *_proxy env variables for Python tests
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5a4d785e1eddf3b66c897a23f6b6c5d0b92392de
Gerrit-Change-Number: 20044
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) [build-support] unset * proxy env variables for Python tests
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20044 )
Change subject: [build-support] unset *_proxy env variables for Python tests
......................................................................
[build-support] unset *_proxy env variables for Python tests
The environment of a Jenkins node might have HTTP/HTTPS proxy configured
to proxy HTTP requests even for 127.0.0.0/8 network and other quirks.
Since Python Kudu tests don't assume any proxying of HTTP/HTTPS requests
to Kudu components listening on 127.0.0.0/8 and other addresses,
let's explicitly unset environment variables that might affect behavior
of the Python libraries like urllib/urllib2 [1][2].
The motivation for this change was observing failures of the new Python
tests introduced with 8c546ae7f560deebb32cb04815377f74470643c6 when
running pre-commit Jenkins jobs on nodes of some peculiar network
configuration.
[1] https://docs.python.org/3/library/urllib.request.html
[2] https://docs.python.org/2/library/urllib2.html
Change-Id: I5a4d785e1eddf3b66c897a23f6b6c5d0b92392de
Reviewed-on: http://gerrit.cloudera.org:8080/20012
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit 459207ff5c103e7d4d60d974504eb8633e188d15)
Reviewed-on: http://gerrit.cloudera.org:8080/20044
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M build-support/jenkins/build-and-test.sh
1 file changed, 12 insertions(+), 1 deletion(-)
Approvals:
Alexey Serbin: Verified
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a4d785e1eddf3b66c897a23f6b6c5d0b92392de
Gerrit-Change-Number: 20044
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) [build-support] unset * proxy env variables for Python tests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20044 )
Change subject: [build-support] unset *_proxy env variables for Python tests
......................................................................
Patch Set 1: Verified+1
unrelated test failures (DEBUG):
* LocationAwareRebalancingParamTest.Rebalance/idx7_rf2_t3_l_1_2_1
* RebalancerAndSingleReplicaTablets.SingleReplicasStayOrMove/4
--
To view, visit http://gerrit.cloudera.org:8080/20044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a4d785e1eddf3b66c897a23f6b6c5d0b92392de
Gerrit-Change-Number: 20044
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 12 Jun 2023 19:38:41 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [build-support] unset * proxy env variables for Python tests
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20044 )
Change subject: [build-support] unset *_proxy env variables for Python tests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a4d785e1eddf3b66c897a23f6b6c5d0b92392de
Gerrit-Change-Number: 20044
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 13 Jun 2023 03:37:30 +0000
Gerrit-HasComments: No