You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/29 20:41:39 UTC
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #6962: GEODE-9758: Configure locator serialization filtering by default on Java 8
dschneider-pivotal commented on a change in pull request #6962:
URL: https://github.com/apache/geode/pull/6962#discussion_r739519268
##########
File path: geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java
##########
@@ -729,6 +762,17 @@ public LocatorState start() {
bindAddress, true, getDistributedSystemProperties(),
getHostnameForClients(),
Paths.get(workingDirectory));
+ if (isJavaVersionAtLeast(JAVA_1_8) && isJavaVersionAtMost(JAVA_1_8)
Review comment:
shouldn't this use the new "isJavaVersion" method you added?
##########
File path: geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java
##########
@@ -709,11 +722,31 @@ private boolean isStartable() {
* @see org.apache.geode.distributed.AbstractLauncher.Status#ONLINE
* @see org.apache.geode.distributed.AbstractLauncher.Status#STARTING
*/
- @SuppressWarnings("deprecation")
public LocatorState start() {
if (isStartable()) {
INSTANCE.compareAndSet(null, this);
+ boolean serializationFilterConfigured = false;
+ if (isJavaVersionAtLeast(JAVA_1_8) && isJavaVersionAtMost(JAVA_1_8)) {
Review comment:
shouldn't this use the new "isJavaVersion" method you added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org