You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/07/20 01:39:26 UTC
Review Request 12783: Fixed Mesos and Protobuf jar targets to build to java6.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12783/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/Makefile.am 6fc38a010b0ec9f0d4b052150852b26f8cb01fab
src/java/mesos.pom.in b88079defb77b45c38cdc1ceb5858b5bbb88e00e
Diff: https://reviews.apache.org/r/12783/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 12783: Fixed Mesos and Protobuf jar targets to build to
java6.
Posted by Vinod Kone <vi...@gmail.com>.
> On July 19, 2013, 11:43 p.m., Ben Mahler wrote:
> > src/Makefile.am, line 480
> > <https://reviews.apache.org/r/12783/diff/1/?file=323856#file323856line480>
> >
> > s/\/ \/
> >
> > Not yours but looks like the backslash formatting is inconsistent in the file.
fixed the whole file.
> On July 19, 2013, 11:43 p.m., Ben Mahler wrote:
> > src/java/mesos.pom.in, lines 97-98
> > <https://reviews.apache.org/r/12783/diff/1/?file=323857#file323857line97>
> >
> > Was this comment for the executions bit you removed?
reverted my change. i'm actually not sure what/why its doing stuff.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12783/#review23561
-----------------------------------------------------------
On July 19, 2013, 11:39 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12783/
> -----------------------------------------------------------
>
> (Updated July 19, 2013, 11:39 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 6fc38a010b0ec9f0d4b052150852b26f8cb01fab
> src/java/mesos.pom.in b88079defb77b45c38cdc1ceb5858b5bbb88e00e
>
> Diff: https://reviews.apache.org/r/12783/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 12783: Fixed Mesos and Protobuf jar targets to build to
java6.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12783/#review23561
-----------------------------------------------------------
src/Makefile.am
<https://reviews.apache.org/r/12783/#comment47459>
s/\/ \/
Not yours but looks like the backslash formatting is inconsistent in the file.
src/java/mesos.pom.in
<https://reviews.apache.org/r/12783/#comment47460>
Was this comment for the executions bit you removed?
- Ben Mahler
On July 19, 2013, 11:39 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12783/
> -----------------------------------------------------------
>
> (Updated July 19, 2013, 11:39 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 6fc38a010b0ec9f0d4b052150852b26f8cb01fab
> src/java/mesos.pom.in b88079defb77b45c38cdc1ceb5858b5bbb88e00e
>
> Diff: https://reviews.apache.org/r/12783/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 12783: Fixed Mesos and Protobuf jar targets to build to
java6.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12783/
-----------------------------------------------------------
(Updated July 21, 2013, 7:15 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased and benm's. nnfr.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/Makefile.am 6fc38a010b0ec9f0d4b052150852b26f8cb01fab
Diff: https://reviews.apache.org/r/12783/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 12783: Fixed Mesos and Protobuf jar targets to build to
java6.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12783/#review23580
-----------------------------------------------------------
Ship it!
src/Makefile.am
<https://reviews.apache.org/r/12783/#comment47468>
From the documentation, it looks like the canonical arguments are 1.3 / 1.4 / 1.5 / 1.6 (and only 5 / 6 are synonyms):
-source release
Specifies the version of source code accepted. The following values for release are allowed:
1.3
The compiler does not support assertions, generics, or other language features introduced after JDK 1.3.
1.4
The compiler accepts code containing assertions, which were introduced in JDK 1.4.
1.5
The compiler accepts code containing generics and other language features introduced in JDK 5.
5
Synonym for 1.5.
1.6
This is the default value. No language changes were introduced in Java SE 6. However, encoding errors in source files are now reported as errors, instead of warnings, as previously.
6
Synonym for 1.6.
-target version
Generate class files that target a specified version of the VM. Class files will run on the specified target and on later versions, but not on earlier versions of the VM. Valid targets are 1.1 1.2 1.3 1.4 1.5 (also 5) and 1.6 (also 6).
The default for -target depends on the value of -source:
If -source is not specified, the value of -target is 1.6
If -source is 1.2, the value of -target is 1.4
If -source is 1.3, the value of -target is 1.4
For all other values of -source, the value of -target is the value of -source.
src/Makefile.am
<https://reviews.apache.org/r/12783/#comment47467>
ditto
src/Makefile.am
<https://reviews.apache.org/r/12783/#comment47466>
ditto
- Ben Mahler
On July 20, 2013, 2:01 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12783/
> -----------------------------------------------------------
>
> (Updated July 20, 2013, 2:01 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 6fc38a010b0ec9f0d4b052150852b26f8cb01fab
>
> Diff: https://reviews.apache.org/r/12783/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 12783: Fixed Mesos and Protobuf jar targets to build to
java6.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12783/
-----------------------------------------------------------
(Updated July 20, 2013, 2:01 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/Makefile.am 6fc38a010b0ec9f0d4b052150852b26f8cb01fab
Diff: https://reviews.apache.org/r/12783/diff/
Testing
-------
make check
Thanks,
Vinod Kone