[jira] Commented: (SOLR-924) Solr: Making finalizers call super.finalize() wrapped in try..finally block

["Noble Paul (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657293#action_12657293 ] 

Noble Paul commented on SOLR-924:
---------------------------------

Why do we need to call a super.finalize() when the super class is java.lang.Object ?

It achieves no purpose





> Solr: Making finalizers call super.finalize() wrapped in try..finally block 
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-924
>                 URL: https://issues.apache.org/jira/browse/SOLR-924
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler, replication (java)
>         Environment: Tomcat 6, JRE 6
>            Reporter: Kay Kay
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-924.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> There are some occurences of finalizers in the code base. While the presence of them is debatable and discussed in a separate JIRA - the ones that are retained are better off wrapped around a try .. finally block to recursively call the finalizer of the super class for proper resource usage unwinding , (in case finalizers get invoked ). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.