RE: svn commit: r1745006 [3/9] - in /openoffice/trunk/main

[Pedro Giffuni <pf...@apache.org>]

Hi Dennis;

So you noticed such changes are burdensome ...

The situation is more or less this so that you understand:

- I have had those changes in my HD for a least a couple of months
now, I was tired of them,
- I considered dropping them but it was quite some effort (time),
and the changes I did to codespell are not public yet.
- While most of them are just comments, some of the strings are user 
visible and have a real effect.
When your software breaks in some evil way and then reports
"Unkown error" you know you can't expect much from the product.
- I of course ran a local build to make sure no breakage was caused.
- This stuff was getting in the way of more a more important
project that I am starting (Can't share the details right now).
So, either I shared it, or I threw it away: if you prefer I just threw
it away, then just say and we can revert it(!).
- There is no code review system in Apache OO to handle such changes.
Trust me: bugzilla won't handle this.
- This type of changes may be big but are pretty non-invasive: even
if we had a *real* code review system (something like phabricator),
someone has to take care of the final changes.

While there are some bogus changes, I do think there was an overall
improvement. It appears you got tired of reviewing the changes
(won't blame you) ... may I suggest you just go ahead and *commit*
your reviews?

Maybe I should have created a branch.. but with the high level of
activity in SVN, I think we could handle it ;).

Subversion is made for collaboration and we are seriously 
under-utilizing it. Let's use subversion for what it's meant to do.
Really, I just wish other committers were more active even when
what most of them do is not all that technical.

Pedro.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org

Re: svn commit: r1745006 [3/9] - in /openoffice/trunk/main

[Marcus <ma...@wtnet.de>]

Am 05/22/2016 11:16 PM, schrieb Pedro Giffuni:

I'm not Dennis but dare to answer.

> - I have had those changes in my HD for a least a couple of months
> now, I was tired of them,
> - I considered dropping them but it was quite some effort (time),
> and the changes I did to codespell are not public yet.

Good choice.

> - While most of them are just comments, some of the strings are user
> visible and have a real effect.

Even better.

> When your software breaks in some evil way and then reports
> "Unkown error" you know you can't expect much from the product.
> - I of course ran a local build to make sure no breakage was caused.
> - This stuff was getting in the way of more a more important
> project that I am starting (Can't share the details right now).
> So, either I shared it, or I threw it away: if you prefer I just threw
> it away, then just say and we can revert it(!).

Sure, it's not a nice and fancy new feature or a long-wished bugfix. 
However, it's action in the code and that's always good. So, I don't 
want to see this reverted.

> - There is no code review system in Apache OO to handle such changes.
> Trust me: bugzilla won't handle this.

It was more than changing some strings here and there. But only because 
you have collected them and not committed as soon as you have seen them.

Normally I favor to created BZ issues to document code changes more 
detailled. However, for correcting only typos? There is no additional 
value for creating *and* filling all the fields.

> Really, I just wish other committers were more active even when
> what most of them do is not all that technical.

I wish I had more lessions about C/C++ in my eductional past. Then I 
could dive into the abyss of AOO code. ;-)

Thanks for your corrections.

Marcus


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org