[GitHub] [maven] hboutemy commented on a diff in pull request #866: [MNG-7596] Upgrade to plexus 3.5.0

[GitBox <gi...@apache.org>]

hboutemy commented on code in PR #866:
URL: https://github.com/apache/maven/pull/866#discussion_r1061205771


##########
maven-xml-impl/src/main/java/org/apache/maven/internal/xml/Xpp3Dom.java:
##########
@@ -180,8 +181,6 @@ public void writeToSerializer(String namespace, XmlSerializer serializer) throws
      *   </ol></li>
      * <li> If mergeSelf == true
      *   <ol type="A">
-     *   <li> if the dominant root node's value is empty, set it to the recessive root node's value</li>
-     *   <li> For each attribute in the recessive root node which is not set in the dominant root node, set it.</li>

Review Comment:
   I don't know if that can help, but big efforts were made in the past on maven-shared-utils reimplementation, with its test suite: https://github.com/apache/maven-shared-utils/blob/master/src/test/java/org/apache/maven/shared/utils/xml/pull/Xpp3DomTest.java
   perhaps that can be reused



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org