You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2014/10/17 15:13:01 UTC

Review Request 26873: Slider. Clear Filters click issue

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26873/
-----------------------------------------------------------

Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.


Bugs: AMBARI-7830
    https://issues.apache.org/jira/browse/AMBARI-7830


Repository: ambari


Description
-------

Go to Slider view.
Click on "clear filters".
"Start time" field is empty, but should be "All Dates"


Diffs
-----

  contrib/views/slider/src/main/resources/ui/app/templates/slider_apps.hbs 129db30 
  contrib/views/slider/src/main/resources/ui/app/views/common/table_view.js 4d5df4a 
  contrib/views/slider/src/main/resources/ui/app/views/slider_apps_view.js 787378b 
  contrib/views/slider/src/main/resources/ui/test/integration/pages/index_test.js b0fc3ba 
  contrib/views/slider/src/main/resources/ui/test/unit/views/slider_apps_view_test.js a3cd020 

Diff: https://reviews.apache.org/r/26873/diff/


Testing
-------

Tests completed in 7097 milliseconds.
112 assertions of 112 passed, 0 failed.


Thanks,

Oleg Nechiporenko

Re: Review Request 26873: Slider. Clear Filters click issue

Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26873/#review57136
-----------------------------------------------------------

Ship it!


Ship It!

- Andriy Babiichuk


On Окт. 17, 2014, 1:13 п.п., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26873/
> -----------------------------------------------------------
> 
> (Updated Окт. 17, 2014, 1:13 п.п.)
> 
> 
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-7830
>     https://issues.apache.org/jira/browse/AMBARI-7830
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Go to Slider view.
> Click on "clear filters".
> "Start time" field is empty, but should be "All Dates"
> 
> 
> Diffs
> -----
> 
>   contrib/views/slider/src/main/resources/ui/app/templates/slider_apps.hbs 129db30 
>   contrib/views/slider/src/main/resources/ui/app/views/common/table_view.js 4d5df4a 
>   contrib/views/slider/src/main/resources/ui/app/views/slider_apps_view.js 787378b 
>   contrib/views/slider/src/main/resources/ui/test/integration/pages/index_test.js b0fc3ba 
>   contrib/views/slider/src/main/resources/ui/test/unit/views/slider_apps_view_test.js a3cd020 
> 
> Diff: https://reviews.apache.org/r/26873/diff/
> 
> 
> Testing
> -------
> 
> Tests completed in 7097 milliseconds.
> 112 assertions of 112 passed, 0 failed.
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Re: Review Request 26873: Slider. Clear Filters click issue

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26873/#review57146
-----------------------------------------------------------

Ship it!


Ship It!

- Aleksandr Kovalenko


On Жов. 17, 2014, 1:13 після полудня, Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26873/
> -----------------------------------------------------------
> 
> (Updated Жов. 17, 2014, 1:13 після полудня)
> 
> 
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-7830
>     https://issues.apache.org/jira/browse/AMBARI-7830
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Go to Slider view.
> Click on "clear filters".
> "Start time" field is empty, but should be "All Dates"
> 
> 
> Diffs
> -----
> 
>   contrib/views/slider/src/main/resources/ui/app/templates/slider_apps.hbs 129db30 
>   contrib/views/slider/src/main/resources/ui/app/views/common/table_view.js 4d5df4a 
>   contrib/views/slider/src/main/resources/ui/app/views/slider_apps_view.js 787378b 
>   contrib/views/slider/src/main/resources/ui/test/integration/pages/index_test.js b0fc3ba 
>   contrib/views/slider/src/main/resources/ui/test/unit/views/slider_apps_view_test.js a3cd020 
> 
> Diff: https://reviews.apache.org/r/26873/diff/
> 
> 
> Testing
> -------
> 
> Tests completed in 7097 milliseconds.
> 112 assertions of 112 passed, 0 failed.
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>