You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/04/08 23:53:36 UTC

[Impala-ASF-CR] IMPAAL-8336: fix flaky ORC memory limit test

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12961


Change subject: IMPAAL-8336: fix flaky ORC memory limit test
......................................................................

IMPAAL-8336: fix flaky ORC memory limit test

Reduces the mem_limit for the ORC version of the
test, which has proven to be flaky.

Testing:
Looped the test for a while locally without any failures.a

I was unable to reproduce the failure seen on CentOS6 jenkins locally,
so we'll just try this tweak and see if it improves this. If not
I can look deeper into it.

Change-Id: Iddcc34183ddcc7c48489739269881bffb1dc85e7
---
M testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit-single-node.test
M tests/query_test/test_nested_types.py
2 files changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/12961/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddcc34183ddcc7c48489739269881bffb1dc85e7
Gerrit-Change-Number: 12961
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8336: fix flaky ORC memory limit test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12961 )

Change subject: IMPALA-8336: fix flaky ORC memory limit test
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddcc34183ddcc7c48489739269881bffb1dc85e7
Gerrit-Change-Number: 12961
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Apr 2019 10:23:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8336: fix flaky ORC memory limit test

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.

Hello Lars Volker, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12961

to look at the new patch set (#2).

Change subject: IMPALA-8336: fix flaky ORC memory limit test
......................................................................

IMPALA-8336: fix flaky ORC memory limit test

Reduces the mem_limit for the ORC version of the
test, which has proven to be flaky.

Testing:
Looped the test for a while locally without any failures.

I was unable to reproduce the failure seen on CentOS6 jenkins locally,
so we'll just try this tweak and see if it improves this. If not
I can look deeper into it.

Change-Id: Iddcc34183ddcc7c48489739269881bffb1dc85e7
---
M testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit-single-node.test
M tests/query_test/test_nested_types.py
2 files changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/12961/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iddcc34183ddcc7c48489739269881bffb1dc85e7
Gerrit-Change-Number: 12961
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] IMPALA-8336: fix flaky ORC memory limit test

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12961 )

Change subject: IMPALA-8336: fix flaky ORC memory limit test
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

Carry

http://gerrit.cloudera.org:8080/#/c/12961/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12961/1//COMMIT_MSG@7
PS1, Line 7: IMPALA
> typo: IMPALA
Done


http://gerrit.cloudera.org:8080/#/c/12961/1//COMMIT_MSG@13
PS1, Line 13: 
> Nit: a character
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddcc34183ddcc7c48489739269881bffb1dc85e7
Gerrit-Change-Number: 12961
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Apr 2019 05:22:43 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8336: fix flaky ORC memory limit test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12961 )

Change subject: IMPALA-8336: fix flaky ORC memory limit test
......................................................................

IMPALA-8336: fix flaky ORC memory limit test

Reduces the mem_limit for the ORC version of the
test, which has proven to be flaky.

Testing:
Looped the test for a while locally without any failures.

I was unable to reproduce the failure seen on CentOS6 jenkins locally,
so we'll just try this tweak and see if it improves this. If not
I can look deeper into it.

Change-Id: Iddcc34183ddcc7c48489739269881bffb1dc85e7
Reviewed-on: http://gerrit.cloudera.org:8080/12961
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit-single-node.test
M tests/query_test/test_nested_types.py
2 files changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddcc34183ddcc7c48489739269881bffb1dc85e7
Gerrit-Change-Number: 12961
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8336: fix flaky ORC memory limit test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12961 )

Change subject: IMPALA-8336: fix flaky ORC memory limit test
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddcc34183ddcc7c48489739269881bffb1dc85e7
Gerrit-Change-Number: 12961
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Apr 2019 05:22:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8336: fix flaky ORC memory limit test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12961 )

Change subject: IMPALA-8336: fix flaky ORC memory limit test
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3999/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/12961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddcc34183ddcc7c48489739269881bffb1dc85e7
Gerrit-Change-Number: 12961
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Apr 2019 05:22:59 +0000
Gerrit-HasComments: No