[GitHub] [kyuubi] yehere commented on a diff in pull request #4417: [KYUUBI #4325] Support replace preparedStatement for Trino-jdbc

["yehere (via GitHub)" <gi...@apache.org>]

yehere commented on code in PR #4417:
URL: https://github.com/apache/kyuubi/pull/4417#discussion_r1123018419


##########
kyuubi-server/src/main/antlr4/org/apache/kyuubi/sql/KyuubiTrinoFeBaseParser.g4:
##########
@@ -54,9 +54,19 @@ statement
       CAST LEFT_PAREN NULL AS SMALLINT RIGHT_PAREN KEY_SEQ COMMA
       CAST LEFT_PAREN NULL AS VARCHAR RIGHT_PAREN PK_NAME
       WHERE FALSE                                                                                       #getPrimaryKeys
+    | EXECUTE IDENTIFIER (USING parameterList)?                                                         #getPrepareParameters
+    | PREPARE IDENTIFIER FROM statement                                                                 #getPrepareSql

Review Comment:
   ok，I misunderstood the api named mapping relationship. It should correspond to the engine's api



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org