You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/02/27 20:07:01 UTC
[GitHub] [couchdb] davisp opened a new pull request #2609: Fix
mem3_sync_event_listener test
davisp opened a new pull request #2609: Fix mem3_sync_event_listener test
URL: https://github.com/apache/couchdb/pull/2609
There's a race between the meck:wait call in setup and killing the
config_event process. Its possible that we could kill and restart the
config_event process after meck:wait returns, but before
gen_event:add_sup_handler is called. More likely, we could end up
killing the config_event gen_event process before its fully handled the
add_sup_handler message and linked the notifier pid.
This avoids the race by waiting for config_event to return that it has
processed the add_sup_handler message instead of relying on meck:wait
for the subscription call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva commented on issue #2609: Fix
mem3_sync_event_listener test
Posted by GitBox <gi...@apache.org>.
nickva commented on issue #2609: Fix mem3_sync_event_listener test
URL: https://github.com/apache/couchdb/pull/2609#issuecomment-592156881
+1
```
make eunit apps=mem3 suites=mem3_sync_event_listener
==> mem3 (compile)
==> rel (compile)
==> asf-master (compile)
==> asf-master (setup_eunit)
==> mem3 (eunit)
======================== EUnit ========================
module 'mem3_sync_event_listener'
Subscribe for configuration changes
mem3_sync_event_listener:267: should_set_sync_delay...[0.052 s] ok
mem3_sync_event_listener:275: should_set_sync_frequency...ok
mem3_sync_event_listener:283: should_restart_listener...[0.501 s] ok
mem3_sync_event_listener:292: should_terminate...[0.051 s] ok
[done in 0.774 s]
[done in 0.854 s]
=======================================================
All 4 tests passed.
==> rel (eunit)
==> asf-master (eunit)
```
Can remove the ugly XKCD debug line if you want
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] davisp commented on issue #2609: Fix
mem3_sync_event_listener test
Posted by GitBox <gi...@apache.org>.
davisp commented on issue #2609: Fix mem3_sync_event_listener test
URL: https://github.com/apache/couchdb/pull/2609#issuecomment-592157173
I think I'll leave it for awhile in case this doesn't fix things completely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] davisp merged pull request #2609: Fix
mem3_sync_event_listener test
Posted by GitBox <gi...@apache.org>.
davisp merged pull request #2609: Fix mem3_sync_event_listener test
URL: https://github.com/apache/couchdb/pull/2609
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services