[GitHub] [apisix-docker] spacewander commented on a change in pull request #162: fix: build failure caused by luarocks connection

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #162:
URL: https://github.com/apache/apisix-docker/pull/162#discussion_r611306448



##########
File path: all-in-one/apisix-dashboard/Dockerfile
##########
@@ -22,7 +22,7 @@ RUN set -x \
     && mkdir ~/.luarocks \
     && luarocks config variables.OPENSSL_LIBDIR /usr/local/openresty/openssl/lib \
     && luarocks config variables.OPENSSL_INCDIR /usr/local/openresty/openssl/include \
-    && luarocks install https://github.com/apache/apisix/raw/master/rockspec/apisix-${APISIX_VERSION}-0.rockspec --tree=/usr/local/apisix/deps \
+    && (for (( i = 0; i < 10; i++ )); do if [[ "$i" -eq 10 ]]; then echo "failed to make deps in time"; exit 1; fi; luarocks install https://github.com/apache/apisix/raw/master/rockspec/apisix-${APISIX_VERSION}-0.rockspec --tree=/usr/local/apisix/deps && break; done) \

Review comment:
       "failed to make deps in time" should be "failed to fetch Lua rocks in time"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org