[jira] Commented: (OFBIZ-3966) Collection task for application jQuery Migration

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917329#action_12917329 ] 

Jacques Le Roux commented on OFBIZ-3966:
----------------------------------------

When reviewing I just wondered about a point. It's not related to you work and was already existing. It's this snippet

{code}
var pars = 'templateGroupId='+templateGroupId+'&productStoreId='+productStoreId+'&pkCategoryId='+pkCategoryId;
var url = '<@o...@ofbizUrl>';

jQuery.ajax({
    url: url,
    type: "GET",
{code}

Is there any issues with that? Because we have a get request, with params in the URL, calling a service. I thought the framework would complain about a security issue. But I'm maybe missing something related to the GET Ajax query not really passing those parameters in the URL?

> Collection task for application jQuery Migration
> ------------------------------------------------
>
>                 Key: OFBIZ-3966
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3966
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: OFBIZ-3966_CommonDependentDropdownMigration.patch, OFBIZ-3966_CommonUiLabels.patch, OFBIZ-3966_EbayApplicationMigration.patch, OFBIZ-3966_EbayStoreApplicationMigration.patch, OFBIZ-3966_ExampleApplicationMigration.patch, OFBIZ-3966_GoogleApplicationMigration.patch, OFBIZ-3966_MarketingApplicationMigration.patch, OFBIZ-3966_OrderApplicationMigration.patch, OFBIZ-3966_PartyApplicationMigration.patch, OFBIZ-3966_ProductApplicationMigration.patch, OFBIZ-3966_ProjectManagerApplicationMigration.patch, OFBIZ-3966_TestToolsApplicationMigration.patch
>
>
> Hi,
> here are some patch files for different components, the most changes are small once. I found it easier to create one task to maintain them.
> There is also a uiLabel update, i hope you can apply the patch. 
> Have a good day Sascha

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.