You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2018/04/03 17:20:44 UTC

[4/5] impala git commit: Do clean as part of "bootstrap_development.sh"

Do clean as part of "bootstrap_development.sh"

This commit instructs bootstrap_development.sh, which is
used in Gerrity-Verify-Dryrun jobs, to clean before
running the build. In the common case, this is essentially
a no-op, because the workspace is new to begin with.

This handles an issue where GVDs would fail if they
happened to run on a machine where a previous build ran
against a workspace where the fe/generated-sources
directories were incompatible. I confirmed that
our clean script does clean out fe/generated-sources
nicely.

Change-Id: I238528ca3938200f0750505a62113630290e8c96
Reviewed-on: http://gerrit.cloudera.org:8080/9841
Reviewed-by: Philip Zeyliger <ph...@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/0c4e1a10
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/0c4e1a10
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/0c4e1a10

Branch: refs/heads/2.x
Commit: 0c4e1a10906d2c96d113edd2a22c0b892233bc8d
Parents: 456aa5d
Author: Philip Zeyliger <ph...@cloudera.com>
Authored: Wed Mar 28 14:30:07 2018 -0700
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Tue Apr 3 00:55:30 2018 +0000

----------------------------------------------------------------------
 bin/bootstrap_development.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/0c4e1a10/bin/bootstrap_development.sh
----------------------------------------------------------------------
diff --git a/bin/bootstrap_development.sh b/bin/bootstrap_development.sh
index 0e31a3f..b6ea369 100755
--- a/bin/bootstrap_development.sh
+++ b/bin/bootstrap_development.sh
@@ -46,7 +46,7 @@ source "${BINDIR}/bootstrap_system.sh"
 export MAX_PYTEST_FAILURES=0
 source bin/impala-config.sh
 export NUM_CONCURRENT_TESTS=$(nproc)
-time -p ./buildall.sh -noclean -format -testdata -skiptests
+time -p ./buildall.sh -format -testdata -skiptests
 
 # To then run the tests:
 # time -p bin/run-all-tests.sh