You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by "Yaolong Liu (Jira)" <ji...@apache.org> on 2022/07/04 07:06:00 UTC

[jira] [Commented] (RATIS-1602) Add a ProxiesPool inner class in NettyServerStreamRpc.

    [ https://issues.apache.org/jira/browse/RATIS-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562037#comment-17562037 ] 

Yaolong Liu commented on RATIS-1602:
------------------------------------

I have merged the pull request. Thanks [~szetszwo]

> Add a ProxiesPool inner class in NettyServerStreamRpc.
> ------------------------------------------------------
>
>                 Key: RATIS-1602
>                 URL: https://issues.apache.org/jira/browse/RATIS-1602
>             Project: Ratis
>          Issue Type: Sub-task
>          Components: server, Streaming
>            Reporter: Tsz-wo Sze
>            Assignee: Tsz-wo Sze
>            Priority: Minor
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> -It is better to have DataStreamRequestByteBuf implementing UncheckedAutoCloseable. Then, we can use try-with-resources to release ByteBuf inside DataStreamRequestByteBuf.-
> There is a List<Proxies> in NettyServerStreamRpc.  It is better to refactor the code to a new ProxiesPool inner class.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)