You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/02/26 17:14:48 UTC

[GitHub] flink pull request: [FLINK-3511] Create example module for Gelly's...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/1725

    [FLINK-3511] Create example module for Gelly's examples and move connector examples to test scope

    This PR creates an example module for Gelly's examples. The new module sets the required dependencies to compile scope so that the examples can be easily run from within an IDE.
    
    Additionally, all the connector examples are moved to the test scope of each connector module.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixLibraries

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1725.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1725
    
----
commit f36ad6010da4619d381f4bdc7a3ea45f9551b577
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-26T13:08:02Z

    [FLINK-3511] [gelly] Introduce flink-gelly-examples module
    
    The new flink-gelly-examples module contains all Java and Scala Gelly examples. The module
    contains compile scope dependencies on flink-java, flink-scala and flink-clients so that
    the examples can be conveniently run from within the IDE.

commit 4612d68e72739f6fe0420ebc4cc6c2bbdd72a8c1
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-26T14:57:45Z

    [FLINK-3511] [avro] Move avro examples to test scope

commit 17561bc863481adfd9c0f9df23c666a376354c70
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-26T15:12:59Z

    [FLINK-3511] [hadoop-compatibility] Move hadoop-compatibility examples to test scope

commit a8745801364624ce13bc195751eaaac1bcccda6f
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-26T15:15:44Z

    [FLINK-3511] [jdbc] Move jdbc examples to test scope and add flink-clients dependency

commit b849f740766664459be08abb6f2a35e9266edda5
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-26T15:21:13Z

    [FLINK-3511] [nifi, elasticsearch] Move nifi and elasticsearch examples to test scope

commit 2c053f58e76bc62658f404139a9192a832084f1a
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-26T15:27:06Z

    [FLINK-3511] [twitter] Move twitter examples to test scope

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3511] Create example module for Gelly's...

Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1725#issuecomment-189383383
  
    +1 to merge once travis passes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3511] Create example module for Gelly's...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1725


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3511] Create example module for Gelly's...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1725#issuecomment-189396303
  
    LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---