You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "gengliangwang (via GitHub)" <gi...@apache.org> on 2023/02/01 04:06:17 UTC

[GitHub] [spark] gengliangwang commented on a diff in pull request #39827: [SPARK-36180][SQL] Support TimestampNTZ type in Hive metastore

gengliangwang commented on code in PR #39827:
URL: https://github.com/apache/spark/pull/39827#discussion_r1092743685


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/types/TimestampNTZType.scala:
##########
@@ -52,6 +52,8 @@ class TimestampNTZType private() extends DatetimeType {
 
   override def typeName: String = "timestamp_ntz"
 
+  override def catalogString: String = "timestamp"

Review Comment:
   I need more thinking on this. Marking this one as WIP



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org