You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/27 16:42:54 UTC
[GitHub] [arrow] jorisvandenbossche opened a new pull request #8539: ARROW-xxxx: [CI][Python] Run fsspec tests on Windows
jorisvandenbossche opened a new pull request #8539:
URL: https://github.com/apache/arrow/pull/8539
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] removed a comment on pull request #8539: ARROW-10462: [Python] Fix usage of fsspec in ParquetDataset causing path issue on Windows
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #8539:
URL: https://github.com/apache/arrow/pull/8539#issuecomment-717384465
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche closed pull request #8539: ARROW-10462: [Python] Fix usage of fsspec in ParquetDataset causing path issue on Windows
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche closed pull request #8539:
URL: https://github.com/apache/arrow/pull/8539
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8539: ARROW-10462: [CI][Python] Run fsspec tests on Windows
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #8539:
URL: https://github.com/apache/arrow/pull/8539#discussion_r516047581
##########
File path: python/pyarrow/filesystem.py
##########
@@ -446,10 +446,6 @@ def _ensure_filesystem(fs):
for mro in inspect.getmro(fs_type):
if mro.__name__ == 'S3FileSystem':
return S3FSWrapper(fs)
- # In case its a simple LocalFileSystem (e.g. dask) use native arrow
- # FS
- elif mro.__name__ == 'LocalFileSystem':
- return LocalFileSystem._get_instance()
Review comment:
The reason this now gives troubles (while this code was already there for more than 2 years), is because with pyarrow >= 2.0, `fsspec` will no longer inherit from pyarrow.filesystem.FileSystem, and so this path was only taken if the passed filesystem was *not* a pyarrow subclass (so before, in pyarrow.fs, we simply didn't take this code path for fsspec filesystems)
##########
File path: python/pyarrow/filesystem.py
##########
@@ -446,10 +446,6 @@ def _ensure_filesystem(fs):
for mro in inspect.getmro(fs_type):
if mro.__name__ == 'S3FileSystem':
return S3FSWrapper(fs)
- # In case its a simple LocalFileSystem (e.g. dask) use native arrow
- # FS
- elif mro.__name__ == 'LocalFileSystem':
- return LocalFileSystem._get_instance()
Review comment:
I *think* it is fine to simply remove this code, as in practice this was also never run anymore with previous pyarrow releases. I suppose this was only ever reached with old fsspec versions that did not yet subclass pyarrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8539: ARROW-xxxx: [CI][Python] Run fsspec tests on Windows
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8539:
URL: https://github.com/apache/arrow/pull/8539#issuecomment-717384465
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8539: ARROW-10462: [CI][Python] Run fsspec tests on Windows
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8539:
URL: https://github.com/apache/arrow/pull/8539#issuecomment-720517018
https://issues.apache.org/jira/browse/ARROW-10462
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org