You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/08 14:12:29 UTC

[GitHub] [beam] eantyshev commented on a diff in pull request #23032: [Tour Of Beam][backend] integration tests and GA workflow

eantyshev commented on code in PR #23032:
URL: https://github.com/apache/beam/pull/23032#discussion_r966023514


##########
learning/tour-of-beam/backend/internal/storage/image/Dockerfile:
##########
@@ -24,7 +24,7 @@ FROM google/cloud-sdk:$GCLOUD_SDK_VERSION
 VOLUME /opt/data
 
 # RUN mkdir -p /opt/data/WEB-INF
-COPY index.yaml /opt/data/WEB-INF/index.yaml
+# COPY index.yaml /opt/data/WEB-INF/index.yaml

Review Comment:
   This was my initial idea of how to validate Datastore indexes: by copying it to the Datastore emulator container
   But that actually doesn't work: emulator updates WEB-INF/index.yaml when it executes the query which requires a composite index. 
   So, in this PR we switch to comparing the generated index.yaml with our VCS version.
   Assuming integration tests covered every possible Datastore query, it produces an index that must work when deployed to Cloud
   
   This line is removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org