[jira] Commented: (MWAR-164) Support for specifying which encoding to use when filtering resources

["Stephane Nicoll (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=182650#action_182650 ] 

Stephane Nicoll commented on MWAR-164:
--------------------------------------

Hey Dennis, are we sure we want to do this?

Why do we have two strategies here (enconding specified in the xml and a parameter for filtered resources). The resources plugin does not offer such feature AFAIK ...

I'd go with something similar to the resources plugin and that would be enough,right?

> Support for specifying which encoding to use when filtering resources
> ---------------------------------------------------------------------
>
>                 Key: MWAR-164
>                 URL: http://jira.codehaus.org/browse/MWAR-164
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-alpha-1
>            Reporter: kai lilleby
>             Fix For: 2.1
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira