You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "chrisdutz (via GitHub)" <gi...@apache.org> on 2023/09/13 08:30:42 UTC
[GitHub] [ratis] chrisdutz opened a new pull request, #917: fix: Updated dropwizard3 to a version with the separated jmx module.
chrisdutz opened a new pull request, #917:
URL: https://github.com/apache/ratis/pull/917
## What changes were proposed in this pull request?
Update to dropwizard3 libraries in version 4.2.7 where the JMX module is now located in a separate module as well as a different package.
Removed obsolete dependency to ganglia (as it seems this was only added for managing the exclusion of one dependency)
## How was this patch tested?
I've run all tests of the module, which admittedly only provide a 51% line coverage.
## Why this update?
In the Apache IoTDB project we consume the Ratis artifacts, but we're already using the newer dropwizard modules, however this causes issues with our Ratis modules (mostly the changed package).
## Why not update to the latest?
I wanted to keep things minimally invasive and 4.2.7 was the first version to have the JMX module relocated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on a diff in pull request #917: fix: Updated dropwizard3 to a version with the separated jmx module.
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on code in PR #917:
URL: https://github.com/apache/ratis/pull/917#discussion_r1324675894
##########
ratis-metrics-dropwizard3/pom.xml:
##########
@@ -25,7 +25,7 @@
<name>Apache Ratis Metrics Dropwizard 3 Implementation</name>
<properties>
- <dropwizard3.version>3.2.5</dropwizard3.version>
+ <dropwizard3.version>4.2.7</dropwizard3.version>
Review Comment:
Since dropwizard 4 is incompatible to dropwizard 3, `ratis-metrics-dropwizard3` must stay in dropwizard 3. For dropwizard 4, please use `ratis-metrics-default` instead. It will use the shaded dropwizard (`org.apache.ratis.thirdparty.com.codahale.metrics.*`) which is dropwizard 4.2.9; see https://github.com/apache/ratis-thirdparty/blob/52f2fe29ff91ad94d5d9a690cba2d4d4ec3ce024/pom.xml#L77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] chrisdutz commented on pull request #917: fix: Updated dropwizard3 to a version with the separated jmx module.
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #917:
URL: https://github.com/apache/ratis/pull/917#issuecomment-1721573701
Thing is, currently Apache IoTDB is consuming the oddly released artifacts from the snapshot2 branch ... I only came across problems as some modules were at different dropwizard versions and I needed that update in Ratis in order to streamline the versions.
I would however imagine, that once 3.0.0 is released, we will pretty quickly transition to that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] chrisdutz closed pull request #917: fix: Updated dropwizard3 to a version with the separated jmx module.
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz closed pull request #917: fix: Updated dropwizard3 to a version with the separated jmx module.
URL: https://github.com/apache/ratis/pull/917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] chrisdutz commented on pull request #917: fix: Updated dropwizard3 to a version with the separated jmx module.
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #917:
URL: https://github.com/apache/ratis/pull/917#issuecomment-1721155193
Yeah ... sorry for the confusion ... will close this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #917: fix: Updated dropwizard3 to a version with the separated jmx module.
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #917:
URL: https://github.com/apache/ratis/pull/917#issuecomment-1721599715
@chrisdutz , I see. We probably will release Ratis 3.0.0 soon; see https://lists.apache.org/thread/wnkyy58d1btxy6h95325n0knv9fftfp8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #917: fix: Updated dropwizard3 to a version with the separated jmx module.
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #917:
URL: https://github.com/apache/ratis/pull/917#issuecomment-1721544160
@chrisdutz , no problem. Please let me know if `ratis-metrics-default` works for you. If not, we could create a `ratis-metrics-dropwizard4` module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org