[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #23155: fix :Extra column in csv while sending csv on email

["Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>]

Antonio-RiveroMartnez commented on code in PR #23155:
URL: https://github.com/apache/superset/pull/23155#discussion_r1119917058


##########
superset/config.py:
##########
@@ -748,6 +748,10 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
 # note: index option should not be overridden
 CSV_EXPORT = {"encoding": "utf-8"}
 
+#It Is used for enable/disable the index sequence for csv which came at email-time,
+#rearly someone want the index in csv so by-default it is false
+CSV_INDEX={"index":False}
+

Review Comment:
   Hey @rohitpawar2811 ! we could use `True/False` in case some users got used to the `row_number` already? as @betodealmeida said, we can change that in future releases along addressing the other problems listed in the issue. Let's add some tests for both cases tho. Thanks again!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org