You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:11:35 UTC
[GitHub] [arrow] westonpace opened a new pull request #10552: ARROW-13110: [C++] Deadlock can happen when using BackgroundGenerator without transferring callbacks
westonpace opened a new pull request #10552:
URL: https://github.com/apache/arrow/pull/10552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz closed pull request #10552: ARROW-13110: [C++] Deadlock can happen when using BackgroundGenerator without transferring callbacks
Posted by GitBox <gi...@apache.org>.
bkietz closed pull request #10552:
URL: https://github.com/apache/arrow/pull/10552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10552: ARROW-13110: [C++] Deadlock can happen when using BackgroundGenerator without transferring callbacks
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10552:
URL: https://github.com/apache/arrow/pull/10552#issuecomment-863612408
https://issues.apache.org/jira/browse/ARROW-13110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz closed pull request #10552: ARROW-13110: [C++] Deadlock can happen when using BackgroundGenerator without transferring callbacks
Posted by GitBox <gi...@apache.org>.
bkietz closed pull request #10552:
URL: https://github.com/apache/arrow/pull/10552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #10552: ARROW-13110: [C++] Deadlock can happen when using BackgroundGenerator without transferring callbacks
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #10552:
URL: https://github.com/apache/arrow/pull/10552#issuecomment-863620407
You mean the one in OneShotFragment? I think that's fine.
Should we add the thread pool as a parameter to MakeBackgroundGenerator? So that you can't forget. (I guess that'd create some churn once we have ARROW-13109 since it would become redundant again.)
This looks like it was a fun issue to debug…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #10552: ARROW-13110: [C++] Deadlock can happen when using BackgroundGenerator without transferring callbacks
Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #10552:
URL: https://github.com/apache/arrow/pull/10552#issuecomment-863612845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a change in pull request #10552: ARROW-13110: [C++] Deadlock can happen when using BackgroundGenerator without transferring callbacks
Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #10552:
URL: https://github.com/apache/arrow/pull/10552#discussion_r654035286
##########
File path: cpp/src/arrow/util/async_generator.h
##########
@@ -20,6 +20,7 @@
#include <cassert>
#include <deque>
#include <queue>
+#include <thread>
Review comment:
This is unfortunate but we could easily add a method for getting the current thread id into thread_pool.h once ARROW-12878 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org