You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/22 23:51:08 UTC
[GitHub] [pulsar] merlimat opened a new pull request #8348: Upgrade to ZooKeeper 3.6.2
merlimat opened a new pull request #8348:
URL: https://github.com/apache/pulsar/pull/8348
### Motivation
Upgrade to latest stable ZK version 3.6.2. The new minor versions brings several advantages:
* Performance improvements (eg: tuning group commit on txn log)
* Prometheus based metrics (so that we can get rid of AspectJ hacky way to instrument ZK)
* New features like persistent recursive watches which would greatly simplify the logic to handle metadata cache invalidations.
The possibility of rollback to previous version has also been validated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #8348: Upgrade to ZooKeeper 3.6.2
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on pull request #8348:
URL: https://github.com/apache/pulsar/pull/8348#issuecomment-714824355
it's compatible with old zk-server version.right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #8348: Upgrade to ZooKeeper 3.6.2
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8348:
URL: https://github.com/apache/pulsar/pull/8348#issuecomment-715325489
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie closed pull request #8348: Upgrade to ZooKeeper 3.6.2
Posted by GitBox <gi...@apache.org>.
sijie closed pull request #8348:
URL: https://github.com/apache/pulsar/pull/8348
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8348: Upgrade to ZooKeeper 3.6.2
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8348:
URL: https://github.com/apache/pulsar/pull/8348#issuecomment-728738345
@merlimat @codelipenghui I am trying to fix this patch now.
btw **it is not a blocker for a release**.
We are also supporting ZooKeeper server in pulsar distribution, and AFAIK adapting the server side can be painful the way we are launching it.
Stay tuned
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8348: Upgrade to ZooKeeper 3.6.2
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8348:
URL: https://github.com/apache/pulsar/pull/8348#issuecomment-728787427
@merlimat I cannot close the issue, please do it for me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #8348: Upgrade to ZooKeeper 3.6.2
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8348:
URL: https://github.com/apache/pulsar/pull/8348#issuecomment-725268885
@merlimat Can you rebase this pull request?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8348: Upgrade to ZooKeeper 3.6.2
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8348:
URL: https://github.com/apache/pulsar/pull/8348#issuecomment-728666746
@eolivelli I will start the 2.7.0 release process soon, I think it's better to onboard this change. Seems @merlimat do not have time, I think you can pick up this fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #8348: Upgrade to ZooKeeper 3.6.2
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8348:
URL: https://github.com/apache/pulsar/pull/8348#issuecomment-729461718
Closed this in favor of #8590
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8348: Upgrade to ZooKeeper 3.6.2
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8348:
URL: https://github.com/apache/pulsar/pull/8348#issuecomment-722263254
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8348: Upgrade to ZooKeeper 3.6.2
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8348:
URL: https://github.com/apache/pulsar/pull/8348#issuecomment-722938582
@codelipenghui it would be interesting to have this patch in 2.7.0
@merlimat unfortunately there are test failure related to this patch, like this one:
```
java.lang.NullPointerException
at org.apache.pulsar.io.flume.node.TestAbstractZooKeeperConfigurationProvider.tearDown(TestAbstractZooKeeperConfigurationProvider.java:75)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8348: Upgrade to ZooKeeper 3.6.2
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8348:
URL: https://github.com/apache/pulsar/pull/8348#issuecomment-728784398
closing in favour of #8590
btw @codelipenghui we cannot make this upgrade, a release on BK is needed, see #8590
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on pull request #8348: Upgrade to ZooKeeper 3.6.2
Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #8348:
URL: https://github.com/apache/pulsar/pull/8348#issuecomment-714827208
> it's compatible with old zk-server version.right?
Yes, unless we start making use of new features in ZK client
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8348: Upgrade to ZooKeeper 3.6.2
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8348:
URL: https://github.com/apache/pulsar/pull/8348#issuecomment-725295305
@merlimat if you do not have time I can pick this up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org