[jira] [Commented] (SOLR-12313) TestInjection#waitForInSyncWithLeader needs improvement.

["Cao Manh Dat (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786644#comment-16786644 ] 

Cao Manh Dat commented on SOLR-12313:
-------------------------------------

After put some thoughts on this. I think the best solution here is completely remove TestInjection#waitForInSyncWithLeader. The purpose of the assertion is reusing other tests to check TLOG replica behave like NRT replica without needed to add more tests. TLOG replicas should have it own tests for testing its behaviour.

The method is already commented out, so I think it won't affect anything If I remove it.

> TestInjection#waitForInSyncWithLeader needs improvement.
> --------------------------------------------------------
>
>                 Key: SOLR-12313
>                 URL: https://issues.apache.org/jira/browse/SOLR-12313
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mark Miller
>            Priority: Major
>
> This really should have some doc for why it would be used.
> I also think it causes BasicDistributedZkTest to take forever for sometimes and perhaps other tests?
> I think checking for uncommitted data is probably a race condition and should be removed.
> Checking index versions should follow the rules that replication does - if the slave is higher than the leader, it's in sync, being equal is not required. If it's expected for a test it should be a specific test that fails. This just introduces massive delays.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org