You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/11 11:11:17 UTC

[GitHub] [beam] codeBehindMe commented on a change in pull request #11976: [BEAM-10169] - ParDo functions with correct output N in their error messages.

codeBehindMe commented on a change in pull request #11976:
URL: https://github.com/apache/beam/pull/11976#discussion_r438710063



##########
File path: sdks/go/pkg/beam/core/util/reflectx/functions.go
##########
@@ -45,3 +45,13 @@ func LoadFunction(ptr uintptr, t reflect.Type) interface{} {
 	*(*unsafe.Pointer)(unsafe.Pointer(v.Addr().Pointer())) = unsafe.Pointer(p)
 	return v.Interface()
 }
+
+//FunctionOutputSize returns the dimensions of the output of a function.
+// Panics if the type is not a function.
+func FunctionOutputSize(fn interface{}) int {

Review comment:
       Hmm I see, perhaps I've gone down a wrong path here then, let me have another review of the code and see what existing tooling is there to resolve this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org