You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/30 14:45:47 UTC

[GitHub] [incubator-doris] sumtumn opened a new pull request, #9867: [feature](function) Add ntile function

sumtumn opened a new pull request, #9867:
URL: https://github.com/apache/incubator-doris/pull/9867

   # Proposed changes
   Add ntile function.
   
   ## Problem Summary:
   Add ntile function.
   For non-vectorized-engine, I just implemented like Impala, rewrite ntile to row_number and count.
   But for vectorized-engine, I implemented WindowFunctionNTile.
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (No)
   2. Has unit tests been added: (Yes)
   3. Has document been added or modified: (Yes)
   4. Does it need to update dependencies: (No)
   5. Are there any changes that cannot be rolled back: (No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] sumtumn commented on a diff in pull request #9867: [feature](function) Add ntile function

Posted by GitBox <gi...@apache.org>.
sumtumn commented on code in PR #9867:
URL: https://github.com/apache/incubator-doris/pull/9867#discussion_r889663380


##########
docs/zh-CN/sql-manual/sql-functions/window-functions/WINDOW-FUNCTION-NTILE.md:
##########
@@ -0,0 +1,43 @@
+---
+{
+    "title": "WINDOW-FUNCTION-NTILE",
+    "language": "zh-CN"
+}
+---
+
+<!--  Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements.  See the NOTICE file distributed with this work for additional information regarding copyright ownership.  The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the License for the specific language governing permissions and limitations under the License. -->
+
+## WINDOW FUNCTION NTILE
+### description
+
+将排序分区中的行划分为特定数量的组。从每个组分配一个从一开始的桶号。对于每一行, NTILE() 函数返回一个桶号,表示行所属的组。
+
+```sql
+NTILE() OVER(partition_by_clause order_by_clause)
+```
+
+### example
+
+```sql
+select x, y, ntile(2) over(partition by x order by y) as rank from int_t;
+
+| x | y    | rank     |
+|---|------|----------|
+| 1 | 1    | 1        |
+| 1 | 2    | 1        |
+| 1 | 2    | 2        |
+| 2 | 1    | 1        |
+| 2 | 2    | 1        |
+| 2 | 3    | 2        |
+| 3 | 1    | 1        |
+| 3 | 1    | 1        |
+| 3 | 2    | 3        |

Review Comment:
   I fixed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] morningman merged pull request #9867: [feature](function) Add ntile function

Posted by GitBox <gi...@apache.org>.
morningman merged PR #9867:
URL: https://github.com/apache/incubator-doris/pull/9867


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9867: [feature](function) Add ntile function

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9867:
URL: https://github.com/apache/incubator-doris/pull/9867#issuecomment-1147000210

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9867: [feature](function) Add ntile function

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9867:
URL: https://github.com/apache/incubator-doris/pull/9867#issuecomment-1147000186

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9867: [feature](function) Add ntile function

Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #9867:
URL: https://github.com/apache/incubator-doris/pull/9867#discussion_r889651612


##########
docs/zh-CN/sql-manual/sql-functions/window-functions/WINDOW-FUNCTION-NTILE.md:
##########
@@ -0,0 +1,43 @@
+---
+{
+    "title": "WINDOW-FUNCTION-NTILE",
+    "language": "zh-CN"
+}
+---
+
+<!--  Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements.  See the NOTICE file distributed with this work for additional information regarding copyright ownership.  The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the License for the specific language governing permissions and limitations under the License. -->
+
+## WINDOW FUNCTION NTILE
+### description
+
+将排序分区中的行划分为特定数量的组。从每个组分配一个从一开始的桶号。对于每一行, NTILE() 函数返回一个桶号,表示行所属的组。

Review Comment:
   I don't even know the meaning `2` of parameter `ntile(2)` after reading the doc. please add the meaning. what could happen if i call `ntile(0)` or `ntile(null)`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9867: [feature](function) Add ntile function

Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #9867:
URL: https://github.com/apache/incubator-doris/pull/9867#discussion_r889651518


##########
docs/zh-CN/sql-manual/sql-functions/window-functions/WINDOW-FUNCTION-NTILE.md:
##########
@@ -0,0 +1,43 @@
+---
+{
+    "title": "WINDOW-FUNCTION-NTILE",
+    "language": "zh-CN"
+}
+---
+
+<!--  Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements.  See the NOTICE file distributed with this work for additional information regarding copyright ownership.  The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the License for the specific language governing permissions and limitations under the License. -->
+
+## WINDOW FUNCTION NTILE
+### description
+
+将排序分区中的行划分为特定数量的组。从每个组分配一个从一开始的桶号。对于每一行, NTILE() 函数返回一个桶号,表示行所属的组。
+
+```sql
+NTILE() OVER(partition_by_clause order_by_clause)
+```
+
+### example
+
+```sql
+select x, y, ntile(2) over(partition by x order by y) as rank from int_t;
+
+| x | y    | rank     |
+|---|------|----------|
+| 1 | 1    | 1        |
+| 1 | 2    | 1        |
+| 1 | 2    | 2        |
+| 2 | 1    | 1        |
+| 2 | 2    | 1        |
+| 2 | 3    | 2        |
+| 3 | 1    | 1        |
+| 3 | 1    | 1        |
+| 3 | 2    | 3        |

Review Comment:
   error, different with english result. should be `2`
   
   



##########
docs/zh-CN/sql-manual/sql-functions/window-functions/WINDOW-FUNCTION-NTILE.md:
##########
@@ -0,0 +1,43 @@
+---
+{
+    "title": "WINDOW-FUNCTION-NTILE",
+    "language": "zh-CN"
+}
+---
+
+<!--  Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements.  See the NOTICE file distributed with this work for additional information regarding copyright ownership.  The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the License for the specific language governing permissions and limitations under the License. -->
+
+## WINDOW FUNCTION NTILE
+### description
+
+将排序分区中的行划分为特定数量的组。从每个组分配一个从一开始的桶号。对于每一行, NTILE() 函数返回一个桶号,表示行所属的组。

Review Comment:
   I don't even know the meaning `2` of parameter `ntile(2)` after reading the doc. please add the meaning  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9867: [feature](function) Add ntile function

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9867:
URL: https://github.com/apache/incubator-doris/pull/9867#issuecomment-1151854564

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] sumtumn commented on a diff in pull request #9867: [feature](function) Add ntile function

Posted by GitBox <gi...@apache.org>.
sumtumn commented on code in PR #9867:
URL: https://github.com/apache/incubator-doris/pull/9867#discussion_r889663793


##########
docs/zh-CN/sql-manual/sql-functions/window-functions/WINDOW-FUNCTION-NTILE.md:
##########
@@ -0,0 +1,43 @@
+---
+{
+    "title": "WINDOW-FUNCTION-NTILE",
+    "language": "zh-CN"
+}
+---
+
+<!--  Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements.  See the NOTICE file distributed with this work for additional information regarding copyright ownership.  The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the License for the specific language governing permissions and limitations under the License. -->
+
+## WINDOW FUNCTION NTILE
+### description
+
+将排序分区中的行划分为特定数量的组。从每个组分配一个从一开始的桶号。对于每一行, NTILE() 函数返回一个桶号,表示行所属的组。

Review Comment:
   I modify the related fucntion description, I think it's much better now.  And in the description, I make it clearly that n must be constant positive integer and check it more strictly in fe. @HappenLee 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org