You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "stevomitric (via GitHub)" <gi...@apache.org> on 2026/09/23 10:24:03 UTC
[PR] [SPARK-59740][SQL][TESTS] Add nanosecond timestamp DML and file roundtrip coverage [spark]
stevomitric opened a new pull request, #58993:
URL: https://github.com/apache/spark/pull/58993
### What changes were proposed in this pull request?
Adds end-to-end tests for the nanosecond timestamp types (TIMESTAMP_NTZ(p) / TIMESTAMP_LTZ(p), p in [7, 9]) over the data-manipulation clauses and file formats that had no nanos coverage:
- TimestampNanosDmlSuiteBase - INSERT / INSERT OVERWRITE / UPDATE / MERGE (all three WHEN arms) / DELETE against an in-memory row-level V2 table, plus a cross-precision write, all keyed on the sub-microsecond remainder across the NTZ and LTZ families.
- TimestampNanosFileRoundTripSuiteBase - Parquet and ORC write→read round-trips asserting the sub-microsecond remainder, precision flooring (p=7/p=8) and NULL all survive, both families.
### Why are the changes needed?
These clauses/formats are the highest-risk untested surface for the nanos preview.
### Does this PR introduce _any_ user-facing change?
No. Test-only.
### How was this patch tested?
New tests. All four subclasses pass (26 tests, ANSI on/off); scalastyle clean.
### Was this patch authored or co-authored using generative AI tooling?
Co-authored-by: Claude Opus 4.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59740][SQL][TESTS] Add nanosecond timestamp DML coverage [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #58993:
URL: https://github.com/apache/spark/pull/58993#issuecomment-5929656124
Thank you @stevomitric!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59740][SQL][TESTS] Add nanosecond timestamp DML coverage [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #58993:
URL: https://github.com/apache/spark/pull/58993#issuecomment-5929672354
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/6ea14af9e20ffb16a51bfe87f05dd18406797ac1
- merged into branch-4.x https://github.com/apache/spark/commit/7e99f2ca9473ecfa3536714b10999e9829967aea
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59740][SQL][TESTS] Add nanosecond timestamp DML coverage [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #58993: [SPARK-59740][SQL][TESTS] Add nanosecond timestamp DML coverage
URL: https://github.com/apache/spark/pull/58993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org