[GitHub] [superset] ktmud commented on pull request #12583: ci: conditionally skip python tests

[GitBox <gi...@apache.org>]

ktmud commented on pull request #12583:
URL: https://github.com/apache/superset/pull/12583#issuecomment-763053240


   You probably wouldn't want to ignore `tests/*.py` for E2E because it also contains some scripts to fill examples data.
   
   I'm also wondering what's the difference between this solution and using Github Action's built-in [`on.<push|pull_request>.paths`](https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestpaths) config?
   
   We can probably get away with something like this:
   
   ```yaml
   name: E2E
   
   on:
     push:
       branches-ignore:
         - "dependabot/**/docs/**"
       paths-ignore:
         - "docs/**"
         - *.md
         - docker/**
         - helm/**
     pull_request:
       paths-ignore:
         - "docs/**"
         - *.md
         - docker/**
         - helm/**
   ```
   
   ```yaml
   # Python MySQL unit tests
   name: Python MySQL
   
   on:
     push:
       branches-ignore:
         - "dependabot/npm_and_yarn/**"
       paths:
         - superset/**
         - tests/**
         - requirements/**
         - scripts/**
         - setup.py
     pull_request:
       paths:
         - superset/**
         - tests/**
         - requirements/**
         - scripts/**
         - setup.py
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org