[jira] [Commented] (LUCENE-7592) EOFException while opening index should be rethrown as CorruptIndexException

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-7592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749339#comment-15749339 ] 

Michael McCandless commented on LUCENE-7592:
--------------------------------------------

+1 to report {{CorruptIndexException}} not an unhandled {{EOFException}}.

But, can you instead use an inner try inside the try-with-resources, so that you can directly pass input to the {{CorruptIndexException}} ctor?  Then you don't need to make your own {{resourceDescription}} I think?

Also, are the solr source changes in this patch separate?

> EOFException while opening index should be rethrown as CorruptIndexException
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-7592
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7592
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Mike Drob
>         Attachments: LUCENE-7592.patch
>
>
> When opening an index, if some files were previously truncated then this should throw the more general CorruptIndexException instead of the specific EOFException to indicate to a consumer that this is not a transient or internally recoverable state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org