[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5311: net/tcp/sendfile: fast retransmit on duplicate acknowledgments (RFC 5681)

[GitBox <gi...@apache.org>]

a-lunev commented on a change in pull request #5311:
URL: https://github.com/apache/incubator-nuttx/pull/5311#discussion_r790059711



##########
File path: net/tcp/tcp_sendfile.c
##########
@@ -242,13 +252,14 @@ static uint16_t sendfile_eventhandler(FAR struct net_driver_s *dev,
         }
 #endif /* CONFIG_NET_IPv4 */
 
-      /* The current acknowledgement number number is the (relative) offset
+      /* The current acknowledgement number is the (relative) offset
        * of the of the next byte needed by the receiver.  The snd_isn is the
        * offset of the first byte to send to the receiver.  The difference
        * is the number of bytes to be acknowledged.
        */
 
-      pstate->snd_acked = TCP_SEQ_SUB(tcp_getsequence(tcp->ackno),
+      ackno = tcp_getsequence(tcp->ackno);
+      pstate->snd_acked = TCP_SEQ_SUB(ackno,

Review comment:
       ackno variable is used later below. I intentionally split the line into two lines.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org