You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/14 22:20:25 UTC

[GitHub] [incubator-tvm] tqchen opened a new pull request #4706: [REFACTOR][IR] Unify IntImm and UIntImm

tqchen opened a new pull request #4706: [REFACTOR][IR] Unify IntImm and UIntImm
URL: https://github.com/apache/incubator-tvm/pull/4706
 
 
   This PR unifies UIntImm and IntImm to simplify the codebase.
   Unsigned integer constants will also be stored as IntImm.
   
   For uint constant that does not fit into int64(rare case), we introduced
   an intrinsic tvm_big_uint_imm to construct such integers by its
   lower and higher 32bits.
   
   
   cc @jroesch @yzhliu @icemelon9 @junrushao1994 @zhiics 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4706: [REFACTOR][IR] Unify IntImm and UIntImm

Posted by GitBox <gi...@apache.org>.
zhiics commented on a change in pull request #4706: [REFACTOR][IR] Unify IntImm and UIntImm
URL: https://github.com/apache/incubator-tvm/pull/4706#discussion_r366610155
 
 

 ##########
 File path: include/tvm/expr_operator.h
 ##########
 @@ -597,6 +583,15 @@ TVM_DLL PrimExpr nearbyint(PrimExpr x);
  */
 TVM_DLL PrimExpr trunc(PrimExpr x);
 
+/*!
+ * \brief Construct a big uint constant by its low 32 bits and high 32bits.
+ * \param dtype The final data type.
+ * \param low The lower 32 bits.
+ * \param high The higher 32 bits.
+ * \return The constructed expression.
+ */
+TVM_DLL PrimExpr BigUIntImm(DataType dtype, int64_t low, int64_t high);
 
 Review comment:
   BigIntImm -> LargeUIntImm ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen merged pull request #4706: [REFACTOR][IR] Unify IntImm and UIntImm

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #4706: [REFACTOR][IR] Unify IntImm and UIntImm
URL: https://github.com/apache/incubator-tvm/pull/4706
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services