You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by st...@apache.org on 2019/08/01 20:16:20 UTC

[impala] 05/05: IMPALA-8636: fix flakiness of ACID INSERT tests

This is an automated email from the ASF dual-hosted git repository.

stakiar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 48bb93d4744f54f609f4f81580b17ef39d1f1a2b
Author: Zoltan Borok-Nagy <bo...@cloudera.com>
AuthorDate: Wed Jul 31 17:02:42 2019 +0200

    IMPALA-8636: fix flakiness of ACID INSERT tests
    
    I had to add @UniqueDatabase.parametrize(sync_ddl=True) to some e2e
    tests because they were broken in exhaustive mode. When the tests run
    with sync_ddl=True then the test files are executed against multiple
    impalads which means that each statement in the .test file is executed
    against a random impalad.
    
    Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
    Reviewed-on: http://gerrit.cloudera.org:8080/13966
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/query_test/test_insert.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/query_test/test_insert.py b/tests/query_test/test_insert.py
index 95df39b..41cce30 100644
--- a/tests/query_test/test_insert.py
+++ b/tests/query_test/test_insert.py
@@ -155,11 +155,13 @@ class TestInsertQueries(ImpalaTestSuite):
     self.hive_client.setMetaConf("metastore.client.capability.check", capability_check)
 
   @SkipIfHive2.acid
+  @UniqueDatabase.parametrize(sync_ddl=True)
   def test_acid_nonacid_insert(self, vector, unique_database):
     self.run_test_case('QueryTest/acid-nonacid-insert', vector, unique_database,
         multiple_impalad=vector.get_value('exec_option')['sync_ddl'] == 1)
 
   @SkipIfHive2.acid
+  @UniqueDatabase.parametrize(sync_ddl=True)
   def test_acid_insert_fail(self, vector, unique_database):
     self.run_test_case('QueryTest/acid-insert-fail', vector, unique_database,
         multiple_impalad=vector.get_value('exec_option')['sync_ddl'] == 1)