You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/01 13:07:52 UTC

[GitHub] [flink] beyond1920 commented on a change in pull request #16024: [FLINK-22038][table-planner-blink] Update TopN to be without rowNumber if rowNumber field is never used by the successor Calc

beyond1920 commented on a change in pull request #16024:
URL: https://github.com/apache/flink/pull/16024#discussion_r643085769



##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkBatchRuleSets.scala
##########
@@ -307,6 +307,9 @@ object FlinkBatchRuleSets {
     CoreRules.PROJECT_TO_CALC,
     FlinkCalcMergeRule.INSTANCE,
 
+    // remove output of rank number when it is not used by successor calc
+    RedundantRankNumberColumnRemoveRule.INSTANCE,

Review comment:
       The rule should be in a HepPlanner phase instead of VolcanoPlanner phase.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org