You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/24 15:33:40 UTC

[GitHub] [hbase] saintstack commented on a change in pull request #2132: HBASE-24767 Change default to false for HBASE-15519 per-user metrics

saintstack commented on a change in pull request #2132:
URL: https://github.com/apache/hbase/pull/2132#discussion_r460128529



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsUserAggregateFactory.java
##########
@@ -28,7 +28,7 @@ private MetricsUserAggregateFactory() {
   }
 
   public static final String METRIC_USER_ENABLED_CONF = "hbase.regionserver.user.metrics.enabled";
-  public static final boolean DEFAULT_METRIC_USER_ENABLED_CONF = true;
+  public static final boolean DEFAULT_METRIC_USER_ENABLED_CONF = false;

Review comment:
       Sounds find if the original config is in hbase-default; this one is not.
   
   We don't have all configs in hbase-default. Too many. Operator would get lost. The boundary between listing in hbase-default or not is not specified unfortunately.  A task to do.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org