[GitHub] [phoenix] kadirozde commented on pull request #1256: PHOENIX-6458 Using global indexes for queries with uncovered columns

[GitBox <gi...@apache.org>]

kadirozde commented on pull request #1256:
URL: https://github.com/apache/phoenix/pull/1256#issuecomment-886114583


   > @lhofhansl ，thank you for reply,
   > Yes , I agree that we should check this in because this implemention is better than existing code which rewrite the sql as `InSubquery`, but I think we should merge the two different implemention in order to not give user two different chocies to achieve the same purpose. One way is remove the existing code and switch to this new implemention, and in the same time , because we could not make sure the index performs better, we should provide an index hint (or just use the existing index hint) or config param to disable it.
   > And furthermore, we should illustratethat we using index and lookupback in the `explain`
   
   @Lars already enhanced the explain plan to indicate the server side merge for uncovered columns in PHOENIX-6409. Regarding to merging this PR and the existing subquery implementation without creating compatibility issues, it is a bit tricky for me now. I need to spend time to figure that out. Would you please create a jira for that? If you like to implement that jira, you would be more than welcome, @comnetwork.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org