You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2021/12/30 07:55:31 UTC

[GitHub] [incubator-seatunnel] leo65535 opened a new issue #903: [Umbrella] optimize the config module

leo65535 opened a new issue #903:
URL: https://github.com/apache/incubator-seatunnel/issues/903


   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22bug%22) and found no similar issues.
   
   
   ### Describe the proposal
   
   SeaTunnel use [config](https://github.com/lightbend/config) to parse app config file, and we did some changes
   
   - Change path token separator from "." to "->"".
   - Added parseObjectForseatunnel() to parse config objects in input, filter, output for seatunnel.
   - Change package name to avoid implementation conflict when using this code with the official typesafe config used by Apache Flink.
   
   But, as we know, it not appropriate that if we copy config sources to SeaTunnel project directly, so this issue aims to improve it.
   This is a big changes, so I will split this issue into two sub issues to finish it.
   
   ### Task list
   
   -[ ]  replace typesafe config
   - [ ] #753
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] leo65535 closed issue #903: [Umbrella] optimize the config module

Posted by GitBox <gi...@apache.org>.
leo65535 closed issue #903:
URL: https://github.com/apache/incubator-seatunnel/issues/903


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] leo65535 commented on issue #903: [Umbrella] optimize the config module

Posted by GitBox <gi...@apache.org>.
leo65535 commented on issue #903:
URL: https://github.com/apache/incubator-seatunnel/issues/903#issuecomment-1004579405


   Fixed at https://github.com/apache/incubator-seatunnel/pull/906, just one issue is enough.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org