[jira] Resolved: (SHINDIG-188) .getData() doesn't return an Collection

["Cassie Doll (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Cassie Doll resolved SHINDIG-188.
---------------------------------

    Resolution: Won't Fix
      Assignee: Cassie Doll

Now that the opensocial 0.8 spec has been modified to get rid of the extra "activities" pointer we don't need to implement this half step. When Shindig supports opensocial 0.8 then this problem will go away.

> .getData() doesn't return an Collection<activities>
> ---------------------------------------------------
>
>                 Key: SHINDIG-188
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-188
>             Project: Shindig
>          Issue Type: Bug
>          Components: OpenSocial  feature (Javascript)
>            Reporter: Alejandro Rivero
>            Assignee: Cassie Doll
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> In file features/opensocial-0.7/jsoncontainer.js
> the function JsonContainer.prototype.newFetchActivitiesRequest
> programs the request to return
>         return {'activities' : new opensocial.Collection(activities)};
> and it should return
>         return new opensocial.Collection(activities) 
> according the API, or at least if the API is interpreted as in the example of FetchPeople.
> Indeed, compare with JsonContainer.prototype.newFetchPeopleRequest = function(idSpec, opt_params) {
> in the same file. This function is programmed to return
>         return new opensocial.Collection(people,...
> and then the javascript code works as told in the Developer guide.
> The only question about/against this correction is if there is already some production system supporting the undocumented result getData().activities.  If it were so, the patch becomes more complex because it should support this legacy code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.